Page MenuHomeFreeBSD
Differential D44590

LinuxKPI: sk_buff: implement skb_queue_splice_tail_init()
ClosedPublic
Actions

Authored by bz on Apr 2 2024, 10:06 AM.
Tags
None
Referenced Files
F102697994: D44590.diff
Sat, Nov 16, 12:24 AM
Unknown Object (File)
Thu, Oct 31, 8:20 AM
Unknown Object (File)
Wed, Oct 23, 7:34 AM
Unknown Object (File)
Oct 10 2024, 9:45 AM
Unknown Object (File)
Oct 4 2024, 11:56 AM
Unknown Object (File)
Oct 3 2024, 5:01 PM
Unknown Object (File)
Oct 1 2024, 1:36 PM
Unknown Object (File)
Oct 1 2024, 1:07 PM
View All 33 Files
Subscribers
emaste
imp

Details

Reviewers
emaste
Group Reviewers
linuxkpi
Commits
rG425edb6fc2d5: LinuxKPI: sk_buff: implement skb_queue_splice_tail_init()
rG6b2686ca9bc6: LinuxKPI: sk_buff: implement skb_queue_splice_tail_init()
rG3d3ec17825a1: LinuxKPI: sk_buff: implement skb_queue_splice_tail_init()
Summary

Implement skb_queue_splice_tail_init() and SKB_DATA_ALIGN() as
needed by the mt76 wireless driver.

Sponsord by: The FreeBD Foundation
MFC after: 3 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 56881
Build 53769: arc lint + arc unit

Event Timeline

bz created this revision.Apr 2 2024, 10:06 AM
Herald added subscribers: emaste, imp. · View Herald TranscriptApr 2 2024, 10:06 AM
bz requested review of this revision.Apr 2 2024, 10:06 AM
Harbormaster completed remote builds in B56868: Diff 136432.Apr 2 2024, 10:06 AM
emaste added inline comments.Apr 2 2024, 12:18 PM
sys/compat/linuxkpi/common/include/linux/skbuff.h
876

from has to be empty?

bz planned changes to this revision.Apr 2 2024, 7:29 PM
bz added inline comments.
sys/compat/linuxkpi/common/include/linux/skbuff.h
876

I'll change it back to the style from the one above. Thank you! NOP -> !NOP

bz updated this revision to Diff 136456.Apr 2 2024, 11:57 PM

Fix logic from NOP to doing something.

Harbormaster completed remote builds in B56881: Diff 136456.Apr 2 2024, 11:57 PM
bz marked an inline comment as done.Apr 2 2024, 11:57 PM

Okay, let's see if it is correct now?

bz added a comment.Apr 14 2024, 11:36 PM

@emaste is the logic correct now?

emaste accepted this revision.Apr 15 2024, 1:20 AM
This revision is now accepted and ready to land.Apr 15 2024, 1:20 AM
Closed by commit rG3d3ec17825a1: LinuxKPI: sk_buff: implement skb_queue_splice_tail_init() (authored by bz). · Explain WhyApr 15 2024, 4:09 PM
This revision was automatically updated to reflect the committed changes.
bz added a commit: rG3d3ec17825a1: LinuxKPI: sk_buff: implement skb_queue_splice_tail_init().
bz added a commit: rG6b2686ca9bc6: LinuxKPI: sk_buff: implement skb_queue_splice_tail_init().Apr 22 2024, 7:44 PM
bz added a commit: rG425edb6fc2d5: LinuxKPI: sk_buff: implement skb_queue_splice_tail_init().Jun 12 2024, 7:17 PM

Revision Contents
Changeset List

PathSize
sys/
compat/
linuxkpi/
common/
include/
linux/
19 lines

Diff 136456

View Options

sys/compat/linuxkpi/common/include/linux/skbuff.h

Loading...