Page MenuHomeFreeBSD

ln: Use stdbool, style nits.
ClosedPublic

Authored by des on Mar 26 2024, 4:12 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Oct 22, 6:37 AM
Unknown Object (File)
Tue, Oct 22, 6:37 AM
Unknown Object (File)
Tue, Oct 22, 6:37 AM
Unknown Object (File)
Tue, Oct 22, 6:37 AM
Unknown Object (File)
Tue, Oct 22, 6:37 AM
Unknown Object (File)
Tue, Oct 22, 6:27 AM
Unknown Object (File)
Sep 18 2024, 1:16 AM
Unknown Object (File)
Sep 8 2024, 8:15 AM
Subscribers

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

des requested review of this revision.Mar 26 2024, 4:12 PM
This revision is now accepted and ready to land.Mar 26 2024, 4:21 PM
allanjude added a subscriber: allanjude.

reviewed-by: allanjude

bin/ln/ln.c
132

This comment should maybe be updated to Implied when fflag is true?

In D44511#1015246, @des wrote:

mark usage() dead

What benefit is this over relying on the exit in there to imply it? Not saying it's wrong, just trying to understand

This revision now requires review to proceed.Mar 26 2024, 4:33 PM
In D44511#1015260, @imp wrote:
In D44511#1015246, @des wrote:

mark usage() dead

What benefit is this over relying on the exit in there to imply it? Not saying it's wrong, just trying to understand

usage() is at the bottom, so the compiler will see calls to it before it realizes that it's dead, unless we tell it.

des marked an inline comment as done.Mar 27 2024, 9:54 AM
This revision was not accepted when it landed; it landed in state Needs Review.Mar 27 2024, 11:29 AM
This revision was automatically updated to reflect the committed changes.