icmp6: bring rate limiting on a par with IPv4
ClosedPublic
Actions

Authored by glebius on Mar 22 2024, 9:49 PM.

Details

Reviewers

tuexen
zlei

Group Reviewers

network

Commits

rGb544e62dd00f: icmp6: bring rate limiting on a par with IPv4
rGa03aff88a144: icmp6: bring rate limiting on a par with IPv4

Summary

Use counter_ratecheck() instead of racy and slow ppsratecheck. Use a
separate counter for every currently known type of ICMPv6. Provide logging
of ratelimit events. Provide jitter to counter open UDP port detection.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

glebius created this revision.Mar 22 2024, 9:49 PM

Herald added subscribers: melifaro, ae, imp. · View Herald TranscriptMar 22 2024, 9:49 PM

glebius requested review of this revision.Mar 22 2024, 9:49 PM

Harbormaster completed remote builds in B56753: Diff 136111.Mar 22 2024, 9:49 PM

glebius added a parent revision: D44481: icmp6: move ICMPv6 related tunables to the files where they are used.Mar 22 2024, 9:49 PM

tuexen accepted this revision.Mar 23 2024, 2:23 PM

This revision is now accepted and ready to land.Mar 23 2024, 2:23 PM

Looks good to me.

Closed by commit rGa03aff88a144: icmp6: bring rate limiting on a par with IPv4 (authored by glebius). · Explain WhyMar 24 2024, 4:22 PM

This revision was automatically updated to reflect the committed changes.

glebius added a commit: rGa03aff88a144: icmp6: bring rate limiting on a par with IPv4.

zlei added a commit: rGb544e62dd00f: icmp6: bring rate limiting on a par with IPv4.Jun 26 2024, 4:52 AM

Revision Contents
Changeset List

Path

Size

sys/

netinet6/

icmp6.c

185 lines

Diff 136166

View Options

icmp6: bring rate limiting on a par with IPv4ClosedPublicActions