Page MenuHomeFreeBSD
Differential D44482

icmp6: bring rate limiting on a par with IPv4
ClosedPublic
Actions

Authored by glebius on Mar 22 2024, 9:49 PM.
Tags
None
Referenced Files
F115637987: D44482.id136111.diff
Sat, Apr 26, 9:20 AM
Unknown Object (File)
Tue, Apr 22, 1:52 PM
Unknown Object (File)
Tue, Apr 22, 6:00 AM
Unknown Object (File)
Sat, Apr 19, 12:24 AM
Unknown Object (File)
Feb 19 2025, 3:38 AM
Unknown Object (File)
Feb 19 2025, 3:12 AM
Unknown Object (File)
Feb 14 2025, 1:11 AM
Unknown Object (File)
Feb 12 2025, 2:04 PM
View All 44 Files
Subscribers
ae
imp
melifaro
zlei

Details

Reviewers
tuexen
zlei
Group Reviewers
network
Commits
rGebda0be762bf: icmp6: bring rate limiting on a par with IPv4
rG1cc0ac5ef37e: icmp6: bring rate limiting on a par with IPv4
rGb544e62dd00f: icmp6: bring rate limiting on a par with IPv4
rGa03aff88a144: icmp6: bring rate limiting on a par with IPv4
Summary

Use counter_ratecheck() instead of racy and slow ppsratecheck. Use a
separate counter for every currently known type of ICMPv6. Provide logging
of ratelimit events. Provide jitter to counter open UDP port detection.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

glebius created this revision.Mar 22 2024, 9:49 PM
Herald added subscribers: melifaro, ae, imp. · View Herald TranscriptMar 22 2024, 9:49 PM
glebius requested review of this revision.Mar 22 2024, 9:49 PM
Harbormaster completed remote builds in B56753: Diff 136111.Mar 22 2024, 9:49 PM
glebius added a parent revision: D44481: icmp6: move ICMPv6 related tunables to the files where they are used.Mar 22 2024, 9:49 PM
tuexen accepted this revision.Mar 23 2024, 2:23 PM
This revision is now accepted and ready to land.Mar 23 2024, 2:23 PM
zlei accepted this revision.Mar 24 2024, 3:17 PM
zlei added a subscriber: zlei.

Looks good to me.

Closed by commit rGa03aff88a144: icmp6: bring rate limiting on a par with IPv4 (authored by glebius). · Explain WhyMar 24 2024, 4:22 PM
This revision was automatically updated to reflect the committed changes.
glebius added a commit: rGa03aff88a144: icmp6: bring rate limiting on a par with IPv4.
zlei added a commit: rGb544e62dd00f: icmp6: bring rate limiting on a par with IPv4.Jun 26 2024, 4:52 AM
tuexen added a commit: rG1cc0ac5ef37e: icmp6: bring rate limiting on a par with IPv4.Feb 12 2025, 2:03 PM
tuexen added a commit: rGebda0be762bf: icmp6: bring rate limiting on a par with IPv4.Feb 13 2025, 4:47 PM

Revision Contents
Changeset List

PathSize
sys/
netinet6/
185 lines

Diff 136166

View Options

sys/netinet6/icmp6.c

Loading...