Page MenuHomeFreeBSD
Differential D44480

icmp6: rate limit our echo replies
ClosedPublic
Actions

Authored by glebius on Mar 22 2024, 9:49 PM.
Tags
None
Referenced Files
F95374167: D44480.id136164.diff
Fri, Sep 20, 12:58 PM
Unknown Object (File)
Mon, Sep 16, 10:18 PM
Unknown Object (File)
Mon, Sep 16, 3:25 PM
Unknown Object (File)
Sun, Sep 8, 7:59 PM
Unknown Object (File)
Fri, Sep 6, 3:50 AM
Unknown Object (File)
Sun, Sep 1, 4:16 AM
Unknown Object (File)
Sat, Aug 31, 9:58 PM
Unknown Object (File)
Mon, Aug 26, 7:48 PM
View All 26 Files
Subscribers
ae
imp
melifaro
zlei

Details

Reviewers
tuexen
zlei
Group Reviewers
network
Commits
rGf6561ff8ee10: icmp6: rate limit our echo replies
rG32aeee8ce7e7: icmp6: rate limit our echo replies
Summary

The generation of ICMP6_ECHO_REPLY bypasses icmp6_error(), thus rate
limit was not applied.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 56751
Build 53639: arc lint + arc unit

Event Timeline

glebius created this revision.Mar 22 2024, 9:49 PM
Herald added subscribers: melifaro, ae, imp. · View Herald TranscriptMar 22 2024, 9:49 PM
glebius requested review of this revision.Mar 22 2024, 9:49 PM
Harbormaster completed remote builds in B56751: Diff 136109.Mar 22 2024, 9:49 PM
glebius added a parent revision: D44479: icmp6: make icmp6_ratelimit() responsible to update the stats counter.Mar 22 2024, 9:49 PM
glebius added a child revision: D44481: icmp6: move ICMPv6 related tunables to the files where they are used.
tuexen accepted this revision.Mar 23 2024, 2:21 PM
This revision is now accepted and ready to land.Mar 23 2024, 2:21 PM
zlei accepted this revision.Mar 24 2024, 2:59 PM
zlei added a subscriber: zlei.

Generally looks good to me.

sys/netinet6/icmp6.c
549

And do not forget to update statistic icp6s_toofreq if D44479 is abandoned.

Closed by commit rG32aeee8ce7e7: icmp6: rate limit our echo replies (authored by glebius). · Explain WhyMar 24 2024, 4:22 PM
This revision was automatically updated to reflect the committed changes.
glebius added a commit: rG32aeee8ce7e7: icmp6: rate limit our echo replies.
zlei added a commit: rGf6561ff8ee10: icmp6: rate limit our echo replies.Jun 26 2024, 4:52 AM

Revision Contents
Changeset List

PathSize
sys/
netinet6/
2 lines

Diff 136109

View Options

sys/netinet6/icmp6.c

Loading...