Added controller state check before issuing the PEL enable to
firmware for sanitization.
Details
Details
Diff Detail
Diff Detail
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
Comment Actions
I am not a big fan of kernel printing something in response to arbitrary user requests, it makes logs messy. Is the error reporting to user is not enough here?
If we keep the printfs, while device_printf() is better than just printf() used in other places (that is dirty), shouldn't we better use mpi3mr_dprint(), respecting configured driver debug level? I see there even special MPI3MR_DEBUG_IOCTL level for IOCTL's.
Comment Actions
ok. I will move those prints under debug flag and will be taken care in the cleanup patch.