linux: make linux_netlink_p->msg_from_linux be able to fail
ClosedPublic
Actions

Authored by glebius on Mar 16 2024, 4:20 PM.

Details

Reviewers

melifaro
dchagin

Commits

rGb977dd1ea5fb: linux: make linux_netlink_p->msg_from_linux be able to fail

Summary

The KPI for this function was misleading. From the NetLink perspective it
looked like a function that: a) allocates new hdr, b) can fail. Neither
was true. Let the function return a error code instead of returning the
same hdr it was passed to. In case if future Linux NetLink compatibility
support calls for reallocating hdr, we can change KPI to pass struct nlmsg
hdr **.

With KPI that returns a error, propagate domain conversion errors all the
way up to NetLink module. This fixes panic when unknown domain is
converted to 0xff and this invalid value is passed into NetLink
processing.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 56645
Build 53533: arc lint + arc unit

Event Timeline

glebius created this revision.Mar 16 2024, 4:20 PM

Herald added a subscriber: imp. · View Herald TranscriptMar 16 2024, 4:20 PM

glebius requested review of this revision.Mar 16 2024, 4:20 PM

Harbormaster completed remote builds in B56645: Diff 135824.Mar 16 2024, 4:20 PM

glebius added a parent revision: D44375: linux: use sa_family_t for address family conversions.Mar 16 2024, 4:20 PM

Add family check to rtnl_route_from_linux(). The strange manipulation with
rt_table blinded me and I didn't notice rt_family going unchecked.

Harbormaster completed remote builds in B56674: Diff 135900.Mar 18 2024, 5:21 PM

Pass hdr as pointer to pointer.

Harbormaster completed remote builds in B56832: Diff 136345.Mar 29 2024, 8:24 PM

melifaro accepted this revision.Mar 29 2024, 8:28 PM

This revision is now accepted and ready to land.Mar 29 2024, 8:28 PM

Closed by commit rGb977dd1ea5fb: linux: make linux_netlink_p->msg_from_linux be able to fail (authored by glebius). · Explain WhyMar 29 2024, 8:36 PM

This revision was automatically updated to reflect the committed changes.

glebius added a commit: rGb977dd1ea5fb: linux: make linux_netlink_p->msg_from_linux be able to fail.

seafork_disroot.org added a subscriber: seafork_disroot.org.May 11 2024, 2:48 AM

seafork_disroot.org added a comment.May 14 2024, 9:12 PM

This comment was removed by seafork_disroot.org.

Apologizes for bumping this review. I've realized that this was most likely an inappropriate place to send my message, and have thusly switched over to the freebsd-emulation mailing list.