Differential D44366

pf: fix dummynet + route-to
ClosedPublic
Actions

Authored by kp on Mar 15 2024, 2:11 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Oct 28, 9:50 PM

	Unknown Object (File)
	Tue, Oct 22, 5:49 AM

	Unknown Object (File)
	Tue, Oct 22, 5:49 AM

	Unknown Object (File)
	Tue, Oct 22, 5:43 AM

	Unknown Object (File)
	Mon, Oct 14, 9:47 PM

	Unknown Object (File)
	Oct 2 2024, 5:54 AM

	Unknown Object (File)
	Sep 24 2024, 3:54 AM

	Unknown Object (File)
	Sep 8 2024, 12:08 PM

View All 25 Files

Subscribers

vegeta_tuxpowered.net

Details

Reviewers

None

Group Reviewers

network
pfsense

Commits

rGc6f111635790: pf: fix dummynet + route-to

Summary

Ensure that we pick the correct dummynet pipe (i.e. forward vs. reverse
direction) when applying route-to.

We mark the processing as outbound so that dummynet will re-inject in
the correct phase of processing after it's done with the packet, but
that will cause us to pick the wrong pipe number. Reverse them so that
the incorrect decision ends up picking the correct pipe.

Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 56616
Build 53504: arc lint + arc unit

Event Timeline

kp created this revision.Mar 15 2024, 2:11 AM

Herald added subscribers: vegeta_tuxpowered.net, glebius, melifaro and 2 others. · View Herald TranscriptMar 15 2024, 2:11 AM

kp requested review of this revision.Mar 15 2024, 2:11 AM

kp added a parent revision: D44365: pf: avoid passing through dummynet multiple times.

Harbormaster completed remote builds in B56616: Diff 135770.Mar 15 2024, 2:12 AM

This revision was not accepted when it landed; it landed in state Needs Review.Mar 19 2024, 3:31 PM

Closed by commit rGc6f111635790: pf: fix dummynet + route-to (authored by kp). · Explain Why

This revision was automatically updated to reflect the committed changes.

kp added a commit: rGc6f111635790: pf: fix dummynet + route-to.

Revision Contents
Changeset List

Path

Size

sys/

netpfil/

pf/

26 lines

tests/

sys/

netpfil/

pf/

65 lines

Diff 135770

sys/netpfil/pf/pf.c

Loading...

tests/sys/netpfil/pf/route_to.sh

Loading...