When one of the physical disk that is part of RAID1 volume is removed, driver may still use the reference the physical disk that is removed while building IO. IO built with a reference to removed physical disk may result into firmware FAULT. This patch fixes this issue by not using any reference to the removed physical disk of RAID1 volume.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Looks good, feel free to take up or not my suggestion.
Next time, please generate diffs with -U99999 so that we get the full context. It's a lot easier to see it here than to jump over to a terminal to look at it in emacs.
sys/dev/mrsas/mrsas_fp.c | ||
---|---|---|
977 | Both of these could be physArm++ |
sys/dev/mrsas/mrsas_fp.c | ||
---|---|---|
977 | Agreed, will do it. |