Page MenuHomeFreeBSD

mrsas: don't issue IO to hot-removed physical disk of RAID1 volume.
ClosedPublic

Authored by sumit.saxena_broadcom.com on Mar 8 2024, 6:34 PM.
Tags
None
Referenced Files
F102904189: D44282.id135635.diff
Mon, Nov 18, 1:34 PM
F102903172: D44282.id135554.diff
Mon, Nov 18, 1:14 PM
Unknown Object (File)
Sat, Nov 16, 3:42 PM
Unknown Object (File)
Thu, Nov 7, 4:24 PM
Unknown Object (File)
Oct 9 2024, 11:21 PM
Unknown Object (File)
Oct 9 2024, 11:21 PM
Unknown Object (File)
Sep 30 2024, 4:35 PM
Unknown Object (File)
Sep 27 2024, 5:35 PM
Subscribers
None

Details

Summary

When one of the physical disk that is part of RAID1 volume is removed, driver may still use the reference the physical disk that is removed while building IO. IO built with a reference to removed physical disk may result into firmware FAULT. This patch fixes this issue by not using any reference to the removed physical disk of RAID1 volume.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Looks good, feel free to take up or not my suggestion.

Next time, please generate diffs with -U99999 so that we get the full context. It's a lot easier to see it here than to jump over to a terminal to look at it in emacs.

sys/dev/mrsas/mrsas_fp.c
977

Both of these could be physArm++

This revision is now accepted and ready to land.Mar 8 2024, 7:21 PM
sys/dev/mrsas/mrsas_fp.c
977

Agreed, will do it.

In D44282#1010108, @imp wrote:

Looks good, feel free to take up or not my suggestion.

Next time, please generate diffs with -U99999 so that we get the full context. It's a lot easier to see it here than to jump over to a terminal to look at it in emacs.

Sure Warner, noted.

This revision now requires review to proceed.Mar 12 2024, 6:20 AM
This revision was not accepted when it landed; it landed in state Needs Review.Mar 12 2024, 10:08 AM
This revision was automatically updated to reflect the committed changes.