Paths

Table of Contentst

tarfs: Improve validation of numeric fields.
ClosedPublic
Actions

Authored by des on Mar 1 2024, 2:58 PM.

Details

Reviewers

sjg
allanjude

Group Reviewers

Klara

Commits

rG8427d94ce056: tarfs: Improve validation of numeric fields.

Summary

MFC after: 3 days
Sponsored by: Juniper Networks, Inc.
Sponsored by: Klara, Inc.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

des created this revision.Mar 1 2024, 2:58 PM

Herald added a subscriber: imp. · View Herald TranscriptMar 1 2024, 2:58 PM

des requested review of this revision.Mar 1 2024, 2:58 PM

Harbormaster completed remote builds in B56364: Diff 135262.Mar 1 2024, 2:58 PM

des added a reviewer: sjg.Mar 1 2024, 3:25 PM

emaste added a subscriber: emaste.Mar 1 2024, 5:25 PM

sjg accepted this revision.Mar 1 2024, 9:53 PM

This revision is now accepted and ready to land.Mar 1 2024, 9:53 PM

des added a child revision: D44202: tarfs: Avoid overflow in exthdr calculation..Mar 4 2024, 11:19 AM

des added a parent revision: D44161: tarfs: Fix two input validation issues..

checksum change moved to D44226

This revision now requires review to proceed.Mar 5 2024, 11:33 AM

Harbormaster completed remote builds in B56445: Diff 135407.Mar 5 2024, 11:33 AM

allanjude added a subscriber: allanjude.Mar 5 2024, 1:47 PM

allanjude added inline comments.

sys/fs/tarfs/tarfs_vfsops.c
154–155	Is this meant to return just an `int` now, rather than an `int64_t`?

des marked an inline comment as done.Mar 5 2024, 5:09 PM

des added inline comments.

sys/fs/tarfs/tarfs_vfsops.c
154–155	Yes, the result is stored in `*num` and the return value is either 0 or an error code.

des marked an inline comment as done.Mar 5 2024, 5:09 PM

des added inline comments.

sys/fs/tarfs/tarfs_vfsops.c
154–155	Oh wait I see what you mean :facepalm:

fix str2base256() return type

Harbormaster completed remote builds in B56452: Diff 135415.Mar 5 2024, 5:11 PM

allanjude accepted this revision.Mar 6 2024, 1:41 PM

This revision is now accepted and ready to land.Mar 6 2024, 1:41 PM

Closed by commit rG8427d94ce056: tarfs: Improve validation of numeric fields. (authored by des). · Explain WhyMar 6 2024, 4:24 PM

This revision was automatically updated to reflect the committed changes.

des added a commit: rG8427d94ce056: tarfs: Improve validation of numeric fields..

des mentioned this in rG08e799c0cc23: tarfs: Fix two input validation issues..Mar 11 2024, 12:36 PM

Revision Contents
Changeset List

Path

Size

sys/

fs/

tarfs/

tarfs_vfsops.c

143 lines

Diff 135457

View Options

sys/fs/tarfs/tarfs_vfsops.c

tarfs: Improve validation of numeric fields.ClosedPublicActions