Page MenuHomeFreeBSD

netlink: fix casts
ClosedPublic

Authored by kp on Feb 26 2024, 6:46 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 17, 10:41 PM
Unknown Object (File)
Feb 23 2025, 5:51 AM
Unknown Object (File)
Feb 22 2025, 2:34 PM
Unknown Object (File)
Feb 22 2025, 1:50 PM
Unknown Object (File)
Feb 22 2025, 1:42 PM
Unknown Object (File)
Feb 9 2025, 3:42 AM
Unknown Object (File)
Feb 8 2025, 5:56 PM
Unknown Object (File)
Feb 8 2025, 2:15 AM

Details

Summary

Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kp requested review of this revision.Feb 26 2024, 6:46 PM
This revision is now accepted and ready to land.Feb 26 2024, 7:24 PM

Will this be MFCed to stable branches ? I see sys/netlink/route/nexthop.c is consuming the fixed function nlattr_get_uint8():

sys/netlink/route/nexthop.c:	{ .type = NHAF_FAMILY, .off = _OUT(nhaf_family), .cb = nlattr_get_uint8 },

Will this be MFCed to stable branches ? I see sys/netlink/route/nexthop.c is consuming the fixed function nlattr_get_uint8():

sys/netlink/route/nexthop.c:	{ .type = NHAF_FAMILY, .off = _OUT(nhaf_family), .cb = nlattr_get_uint8 },

We probably should, although as far as I know this doesn't actually break anything. It's just something that caught my eye as I was looking at this code.

This revision was automatically updated to reflect the committed changes.