Page MenuHomeFreeBSD
Differential D43990

md5: Fix GNU check mode.
ClosedPublic
Actions

Authored by des on Feb 20 2024, 5:30 PM.
Tags
None
Referenced Files
F102114791: D43990.diff
Thu, Nov 7, 7:24 PM
Unknown Object (File)
Wed, Nov 6, 4:22 AM
Unknown Object (File)
Tue, Nov 5, 4:04 AM
Unknown Object (File)
Thu, Oct 31, 1:49 PM
Unknown Object (File)
Mon, Oct 21, 12:08 AM
Unknown Object (File)
Mon, Oct 21, 12:07 AM
Unknown Object (File)
Mon, Oct 21, 12:07 AM
Unknown Object (File)
Sun, Oct 20, 3:18 PM
View All 62 Files
Subscribers
imp
markj
rbranco_suse.com

Details

Reviewers
imp
markj
allanjude
Group Reviewers
Klara
Commits
rGc05533d97ac1: md5: Fix GNU check mode.
Summary

Fixes: 9b20849bc5f1b500f2de7aeca77f0e6556069bbb
MFC after: 1 week
Sponsored by: Klara, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

des created this revision.Feb 20 2024, 5:30 PM
Herald added a subscriber: imp. · View Herald TranscriptFeb 20 2024, 5:30 PM
des requested review of this revision.Feb 20 2024, 5:30 PM
Harbormaster completed remote builds in B56119: Diff 134737.Feb 20 2024, 5:30 PM
des added a parent revision: D43989: md5: Fix Perl mode long options..Feb 20 2024, 5:30 PM
des added a child revision: D43991: md5: Untabify declarations..
imp accepted this revision.Feb 20 2024, 5:50 PM

I'd explain a little bit more what was broken. Looks like maybe it was checking for a verbatim match before peeling off the special character, but I'm not sure.

This revision is now accepted and ready to land.Feb 20 2024, 5:50 PM
markj added a subscriber: markj.Feb 20 2024, 6:08 PM
markj added inline comments.
sbin/md5/md5.c
374

Should this be rec->input_mode = input_mode?

620

Not necessary for this diff, but IMO it'd be better to pass these as parameters to MDInput() and MDOutput() rather than switching the global value like this.

des updated this revision to Diff 134743.Feb 20 2024, 6:12 PM
des marked 2 inline comments as done.

like markj said

This revision now requires review to proceed.Feb 20 2024, 6:12 PM
Harbormaster completed remote builds in B56124: Diff 134743.Feb 20 2024, 6:12 PM
des added inline comments.Feb 20 2024, 6:13 PM
sbin/md5/md5.c
374

I guess that makes more sense.

620

I'm just fixing what's broken...

markj accepted this revision as: markj.Feb 20 2024, 6:14 PM
This revision is now accepted and ready to land.Feb 20 2024, 6:14 PM
des added a comment.Feb 20 2024, 6:14 PM
In D43990#1003525, @imp wrote:

I'd explain a little bit more what was broken. Looks like maybe it was checking for a verbatim match before peeling off the special character, but I'm not sure.

It was discarding the input mode.

allanjude accepted this revision as: allanjude.Feb 20 2024, 7:32 PM
Closed by commit rGc05533d97ac1: md5: Fix GNU check mode. (authored by des). · Explain WhyFeb 20 2024, 10:06 PM
This revision was automatically updated to reflect the committed changes.
des added a commit: rGc05533d97ac1: md5: Fix GNU check mode..
rbranco_suse.com added a subscriber: rbranco_suse.com.Feb 22 2024, 8:58 AM

The manpage states:

Note that this implementation does not differentiate between binary and text mode.

des added a comment.Feb 22 2024, 5:19 PM
In D43990#1004292, @rbranco_suse.com wrote:

The manpage states:

Note that this implementation does not differentiate between binary and text mode.

Correct. It still differentiates between binary / text, universal, and bits.

des mentioned this in rG1288891878d9: md5: Accept "-" as alias for stdin..Feb 24 2024, 12:16 PM

Revision Contents
Changeset List

PathSize
sbin/
md5/
36 lines

Diff 134759

View Options

sbin/md5/md5.c

Loading...