Differential D43961
ata_da: add quirk to disable NCQ TRIM for Samsung 860/870 SSDs Authored by avg on Feb 18 2024, 3:47 PM. Tags None Referenced Files
Subscribers None
Details
NCQ TRIM for Samsung 860/870 SSDs results in data corruption on systems This can be easily reproduced using ZFS which uses TRIM and is able to Linux bug report for this issue: https://bugzilla.kernel.org/show_bug.cgi?id=201693 Since at present we can not limit a quirk based on the contorller / SIM,
Diff Detail
Event TimelineComment Actions I first-hand experienced problems with a device identified as Samsung SSD 870 EVO 250GB SVT02B6Q. Comment Actions I should clarify that I didn't see just silent data corruption, there were read and write errors as well. Jul 12 11:32:19 trant kernel: ada4 at ahcich8 bus 0 scbus8 target 0 lun 0 Jul 12 11:32:19 trant kernel: ada4: <Samsung SSD 870 EVO 250GB SVT02B6Q> ACS-4 ATA SATA 3.x device Jul 12 11:32:19 trant kernel: ada4: Serial Number S6PENU0W400952M Jul 12 11:32:19 trant kernel: ada4: 600.000MB/s transfers (SATA 3.x, UDMA6, PIO 512bytes) Jul 12 11:32:19 trant kernel: ada4: Command Queueing enabled Jul 12 11:32:19 trant kernel: ada4: 238475MB (488397168 512 byte sectors) Jul 12 11:41:20 trant kernel: (ada4:ahcich8:0:0:0): WRITE_FPDMA_QUEUED. ACB: 61 10 88 0d 9c 40 0c 00 00 00 00 00 Jul 12 11:41:20 trant kernel: (ada4:ahcich8:0:0:0): CAM status: Uncorrectable parity/CRC error Jul 12 11:41:20 trant kernel: (ada4:ahcich8:0:0:0): Error 5, Retries exhausted Jul 12 11:42:10 trant kernel: (ada4:ahcich8:0:0:0): READ_FPDMA_QUEUED. ACB: 60 10 10 07 40 40 01 00 00 00 00 00 Jul 12 11:42:10 trant kernel: (ada4:ahcich8:0:0:0): CAM status: Uncorrectable parity/CRC error Jul 12 11:42:10 trant kernel: (ada4:ahcich8:0:0:0): Retrying command, 1 more tries remain Comment Actions I've been looking at bringing 8n the list from Linux that exploded based on this. These errors are not drive errors, but cable errors. Uncorrectable parity/CRC errors aren't the drive telling you that the data on it is bad (though it may well be), but it is the controller telling you that there were errors transferring the data. You may get a reprieve with these changes, or you may find it was a false positive and these problems persist. I've been looking to bring over the entire list from Linux. At the time I originally did this feature, and for a year or two after, I kept it up to date. Then there were not updates to Linux's list for a while so I stopped, but it's clear there's about a dozen drives that should be black listed.... In general, I don't think problems like this are specific to a drive / controller combo, especially with the controller is the most common controller out there. If you read the entire bug report, this seems to be related to firmware version and many reports don't include the controller. So I'd treat the 'it is confined to one type of controller' with a fair amount of skepticism. It's more likely a bad firmware version... however, since we don't have good data on that. globally is fine. Now, having said all that, these drives have a hit or miss hiss in general (there's a long history of a few people having issues that couldn't quite be nailed down and never quite attributed to a known cause). Comment Actions Just want to comment that based on the errors I initially thought that the problem was a bad cable or SATA port, so I tried a few cables and a few ports on the motherboard, all with the same result. I went through the Linux bug report again and I see that people reported the same or similar issue with some Marvell and ASMedia controllers. Comment Actions Also, I'd be happier if we could also create a pim value known bad controllers could set. I strongly doubt these are the only drives affected if the controller matters. Can you report pciconf -lv for your controller? Comment Actions The controller is ahci2@pci0:0:17:0: class=0x010601 rev=0x40 hdr=0x00 vendor=0x1002 device=0x4391 subvendor=0x1043 subdevice=0x84dd
vendor = 'Advanced Micro Devices, Inc. [AMD/ATI]'
device = 'SB7x0/SB8x0/SB9x0 SATA Controller [AHCI mode]'
class = mass storage
subclass = SATAComment Actions I see them in drivers/ata/libata-core.c { "Samsung SSD 860*", NULL, ATA_HORKAGE_NO_NCQ_TRIM | ATA_HORKAGE_ZERO_AFTER_TRIM | ATA_HORKAGE_NO_NCQ_ON_ATI }, { "Samsung SSD 870*", NULL, ATA_HORKAGE_NO_NCQ_TRIM | ATA_HORKAGE_ZERO_AFTER_TRIM | ATA_HORKAGE_NO_NCQ_ON_ATI } Comment Actions Also, it might be better to fix the 850 to match the pattern 8[567]0* as well rather than introduce additional entries... Though Samsung shifted their marketing name to PM8xx (and some of those drives are known bad and in the list). I have this in one of my trees from the last time I did a linux sync (I missed one), with the above suggestion iff --git a/sys/cam/ata/ata_da.c b/sys/cam/ata/ata_da.c index de8563a6c229..efdd27c615fa 100644 --- a/sys/cam/ata/ata_da.c +++ b/sys/cam/ata/ata_da.c @@ -498,10 +498,10 @@ static struct ada_quirk_entry ada_quirk_table[] = }, { /* - * Crucial M550 SSDs + * Crucial M5[15]0 SSDs * NCQ Trim doesn't work, but only on MU01 firmware */ - { T_DIRECT, SIP_MEDIA_FIXED, "*", "Crucial CT*M550*", "MU01" }, + { T_DIRECT, SIP_MEDIA_FIXED, "*", "Crucial CT*M5[15]0*", "MU01" }, /*quirks*/ADA_Q_NCQ_TRIM_BROKEN }, { @@ -722,10 +722,10 @@ static struct ada_quirk_entry ada_quirk_table[] = }, { /* - * Samsung 850 SSDs + * Samsung 850 SSDs, 860 and 870s also implicated, so be conservative * 4k optimised, NCQ TRIM broken (normal TRIM fine) */ - { T_DIRECT, SIP_MEDIA_FIXED, "*", "Samsung SSD 850*", "*" }, + { T_DIRECT, SIP_MEDIA_FIXED, "*", "Samsung SSD 8[567]0*", "*" }, /*quirks*/ADA_Q_4K | ADA_Q_NCQ_TRIM_BROKEN }, { Comment Actions Based on earlier entries for Samsung 8x0 drives in ata_da.c and scsi_da.c it seems that a separate entry per model line was a preference. Comment Actions Yea... lsi does no ncq trim. I'd bet higher money it's disabled in the controller on linux... I'd like to do similar on FreeBSD. I'd be super surprised I if it were only the drive combo... Comment Actions Hmm that must have been added after my last git update... I'll have to see what else is there.., |