Page MenuHomeFreeBSD
Differential D43816

VFS: update VOP_FSYNC() debug check to reflect actual locking policy
ClosedPublic
Actions

Authored by jah on Feb 10 2024, 4:35 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 19, 3:47 AM
Unknown Object (File)
Sat, Feb 22, 8:20 AM
Unknown Object (File)
Jan 30 2025, 2:39 AM
Unknown Object (File)
Jan 24 2025, 2:59 AM
Unknown Object (File)
Jan 10 2025, 10:48 AM
Unknown Object (File)
Jan 10 2025, 10:33 AM
Unknown Object (File)
Jan 10 2025, 4:49 AM
Unknown Object (File)
Jan 9 2025, 7:57 AM
View All 37 Files
Subscribers
imp

Details

Reviewers
kib
markj
olce
Commits
rGd0bb255d1fcb: VFS: update VOP_FSYNC() debug check to reflect actual locking policy
rG9530182e371d: VFS: update VOP_FSYNC() debug check to reflect actual locking policy
Summary

Shared vs. exclusive locking is determined not by MNT_EXTENDED_SHARED
but by MNT_SHARED_WRITES (although there are several places that
ignore this and simply always use an exclusive lock). Also add a
comment on the possible difference between VOP_GETWRITEMOUNT(vp)
and vp->v_mount on this path.

Found by local testing of unionfs atop ZFS with DEBUG_VFS_LOCKS.

MFC after: 2 weeks

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
sys/
kern/
17 lines

Diff 134565

View Options

sys/kern/vfs_subr.c

Loading...