libjail: Guard against programmer error in jailparam_export()
ClosedPublic
Actions

Authored by markj on Feb 4 2024, 2:23 AM.

Details

Reviewers

Group Reviewers

Commits

rG5e21d7cd3119: libjail: Guard against programmer error in jailparam_export()
rGdfabf3efaa79: libjail: Guard against programmer error in jailparam_export()

Summary

If the caller didn't use jailparam_import() to fetch the parameter
value, an attempt to export it will trigger a segfault. Make it a bit
easier to figure out what's happening in this situation.

PR: 276809

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 55788
Build 52677: arc lint + arc unit

Event Timeline

markj created this revision.Feb 4 2024, 2:23 AM

Herald added a subscriber: imp. · View Herald TranscriptFeb 4 2024, 2:23 AM

markj requested review of this revision.Feb 4 2024, 2:23 AM

Harbormaster completed remote builds in B55788: Diff 133827.Feb 4 2024, 2:23 AM

Sure, looks helpful for just such a situation.

This revision is now accepted and ready to land.Feb 4 2024, 10:38 PM

Closed by commit rGdfabf3efaa79: libjail: Guard against programmer error in jailparam_export() (authored by markj). · Explain WhyFeb 4 2024, 10:53 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rGdfabf3efaa79: libjail: Guard against programmer error in jailparam_export().

markj added a commit: rG5e21d7cd3119: libjail: Guard against programmer error in jailparam_export().Feb 11 2024, 3:17 PM

Revision Contents
Changeset List

Path

Size

lib/

libjail/

jail.c

6 lines

Diff 133827

View Options

libjail: Guard against programmer error in jailparam_export()ClosedPublicActions