bsdinstall: complete whitelabeling the installer
ClosedPublic
Actions

Authored by oshogbo on Jan 28 2024, 6:57 PM.

Details

Reviewers

allanjude
brd
asiciliano
imp

Commits

rGcd724c25928d: bsdinstall: complete whitelabeling the installer

Summary

The commit 147585b4893bc38698aaa971af336b241477eac3 introduces
whitlabeling. This commit addresses couple more places where the
os name was missed.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 55669
Build 52558: arc lint + arc unit

Event Timeline

oshogbo created this revision.Jan 28 2024, 6:57 PM

Herald added subscribers: jrtc27, imp. · View Herald TranscriptJan 28 2024, 6:57 PM

oshogbo requested review of this revision.Jan 28 2024, 6:57 PM

Harbormaster completed remote builds in B55669: Diff 133468.Jan 28 2024, 6:57 PM

oshogbo added reviewers: allanjude, brd, asiciliano.Jan 28 2024, 6:58 PM

Seems reasonable to me.
Who will be using this?

This revision is now accepted and ready to land.Jan 28 2024, 8:43 PM

LGTM

usr.sbin/bsdinstall/startbsdinstall
4	Off-topic/bikeshed, an idea for the future, I wrote a similar comment in another review. Here we are importing thousands lines of code to know only the value of OSNAME. Paradoxically it is not used by bsdconfig so we could move OSNAME="FreeBSD" to bsdinstall. Maybe in bsdinstall/startbsdinstall or a new file bsdinstall/customization. It could be easier to document and change for users than to have a variable in an unrelated bsdconfig file.

In D43638#995136, @imp wrote:

Seems reasonable to me.
Who will be using this?

I don't have any particular user in mind. It was originally started by Netgate. However, I can imagine that any product that uses a FreeBSD customized installer like pfsense, opnsense, etc. might fight that useful. Or actually, anything that wants to brand FreeBSD.