bsdinstall: separate out dist selection in prep for pkgbase support

[brd]

Test Plan

Install in a VM over and over

[asiciliano]

LGTM. I tested the new selectdists file in the my XFCE Terminal. I wrote some tip, you can consider or ignore.

Since I haven't used pkgbase yet, I would add somebody interested.

usr.sbin/bsdinstall/scripts/selectdists

32

Off-topic, just an idea we could discuss in the future. Here, in this file, we are importing thousand lines of code just to know the value of: $OSNAME and $DIALOG_TERMINAL_PASSTHRU_FD. We could create a file in bsdinstall (ex. bsdinstall/customization) or using an existing file (ex. bsdinstall/startbsdinstall) only for settings the installer (something like VAR=VALUE); OSNAME seems a perfect candidate to be on this file. This file could be an easier way to customize the installer for users/sysadmin (instead of looking for files in bsdconfig). Moreover all the variables in 1 file could a be an easy way to init/re-init them, so finally we can start to implement the "installer restart" feature.

47

These 2 lines f_dialog_title and f_dialog_backtitle are not used so they could be deleted. Indeed the following --checklist and --msgbox use explicitly their --backtitle and --title.

52

You did a change: bsddialog -> $DIALOG, so do you want to use Xdialog and/or lgpl-dialog? Anyway if you need Xdialog you could use the "bsdconfig API" to build this checklist as Xdialog is not able to calculate the correct autosizing at least on my laptop ("0 0 0 ..." following four lines).{F75635540}

72

bsddialog -> $DIALOG change like above. If you use $DIALOG, you could use the "bsdconfig api": to build f_dialog_msgbox, to get errors, autosizing, and so on; it creates a msgbox suitable for multi front-end.

[jrtc27]

usr.sbin/bsdinstall/startbsdinstall

9

This seems pretty strange to do here. Why isn't it the default?

[brd]

usr.sbin/bsdinstall/scripts/selectdists

32

That is a good point..

47

Will do in the next version

52

good point.. I'll switch it back, I was just trying to be more flexible but not sure it is worth it.

usr.sbin/bsdinstall/startbsdinstall

9

Because in the near future it won't be the default

[jrtc27]

usr.sbin/bsdinstall/startbsdinstall

9

Then change the default when the default should change? This doesn't belong here. Besides, I'd expect a transitional period where there's a menu asking which you'd like; pkgbase is coming along but it still seems like it isn't quite battle-tested enough to be the only way to install FreeBSD.

[emaste]

usr.sbin/bsdinstall/startbsdinstall

9

What I'd like to do is have a menu in the boot loader that sets a variable for experimental features, so that it can be available in snapshots but still somewhat hidden

[brd]

Address feedback

[jrtc27]

usr.sbin/bsdinstall/startbsdinstall

9

That seems reasonable. But that still doesn't make this line belong here.