open: make non-POSIX errno value more apparent
ClosedPublic
Actions

Authored by emaste on Jan 26 2024, 3:25 PM.

Details

Reviewers

jilles
markj

Commits

rGc3c75c142c0c: open: make non-POSIX errno value more apparent
rGea6a6b63e1fd: open: make non-POSIX errno value more apparent

Summary

When O_NOFOLLOW is specified and the target is a symbolic link FreeBSD
sets errno to a value different to that specified by POSIX.  A note to
this effect was added in commit 295159dfa3ed, but I missed it when
reading through the list of errno values.  In the errno list, add an
explicit note and reference to the note in the STANDARDS section.

PR:             214633

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

emaste requested review of this revision.Jan 26 2024, 3:25 PM

emaste created this revision.

Thanks. This would have saved me a few minutes last night.

This revision is now accepted and ready to land.Jan 26 2024, 3:32 PM

Closed by commit rGea6a6b63e1fd: open: make non-POSIX errno value more apparent (authored by emaste). · Explain WhyJan 26 2024, 3:39 PM

This revision was automatically updated to reflect the committed changes.

emaste added a commit: rGea6a6b63e1fd: open: make non-POSIX errno value more apparent.

Herald added a subscriber: imp. · View Herald TranscriptJan 26 2024, 3:39 PM

I thought that .Tn was deprecated...

I thought that .Tn was deprecated...

Ah, there is some debate on that topic, but mandoc does indeed suggest it not be used. I just copied it from the existing .Tn POSIX below, and wouldn't object to a pass over e.g. all of libc's man pages.

emaste added a commit: rGc3c75c142c0c: open: make non-POSIX errno value more apparent.Mar 22 2024, 1:33 PM