Page MenuHomeFreeBSD

pfil: PFIL_PASS never frees the mbuf
ClosedPublic

Authored by kp on Jan 26 2024, 2:45 PM.
Tags
None
Referenced Files
F109288961: D43617.diff
Mon, Feb 3, 2:57 AM
Unknown Object (File)
Fri, Jan 17, 3:00 PM
Unknown Object (File)
Fri, Jan 17, 3:31 AM
Unknown Object (File)
Dec 18 2024, 8:38 AM
Unknown Object (File)
Nov 30 2024, 4:53 PM
Unknown Object (File)
Nov 30 2024, 3:49 PM
Unknown Object (File)
Nov 30 2024, 3:49 PM
Unknown Object (File)
Nov 27 2024, 7:43 PM

Details

Summary

pfil hooks (i.e. firewalls) may pass, modify or free the mbuf passed
to them. (E.g. when rejecting a packet, or when gathering up packets
for reassembly).

If the hook returns PFIL_PASS the mbuf must still be present. Assert
this in pfil_mem_common() and ensure that ipfilter follows this
convention. pf and ipfw already did.
Similarly, if the hook returns PFIL_DROPPED or PFIL_CONSUMED the mbuf
must have been freed (or now be owned by the firewall for further
processing, like packet scheduling or reassembly).

This allows us to remove a few extraneous NULL checks.

Suggested by: tuexen
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable