Page MenuHomeFreeBSD

pfil: PFIL_PASS never frees the mbuf
ClosedPublic

Authored by kp on Jan 26 2024, 2:45 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 3, 4:56 AM
Unknown Object (File)
Mon, Mar 3, 3:36 AM
Unknown Object (File)
Mon, Mar 3, 3:07 AM
Unknown Object (File)
Sun, Mar 2, 9:14 PM
Unknown Object (File)
Feb 14 2025, 7:37 AM
Unknown Object (File)
Feb 13 2025, 12:25 PM
Unknown Object (File)
Feb 9 2025, 8:55 AM
Unknown Object (File)
Feb 3 2025, 6:10 AM

Details

Summary

pfil hooks (i.e. firewalls) may pass, modify or free the mbuf passed
to them. (E.g. when rejecting a packet, or when gathering up packets
for reassembly).

If the hook returns PFIL_PASS the mbuf must still be present. Assert
this in pfil_mem_common() and ensure that ipfilter follows this
convention. pf and ipfw already did.
Similarly, if the hook returns PFIL_DROPPED or PFIL_CONSUMED the mbuf
must have been freed (or now be owned by the firewall for further
processing, like packet scheduling or reassembly).

This allows us to remove a few extraneous NULL checks.

Suggested by: tuexen
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable