Page MenuHomeFreeBSD
Differential D43533

bintrans: Avoid leaking a stack pointer through a global.
AbandonedPublic
Actions

Authored by des on Jan 21 2024, 5:37 PM.
Tags
None
Referenced Files
F97152855: D43533.diff
Fri, Sep 27, 11:18 PM
Unknown Object (File)
Sat, Sep 21, 7:10 AM
Unknown Object (File)
Tue, Sep 17, 1:20 PM
Unknown Object (File)
Sun, Sep 8, 12:48 PM
Unknown Object (File)
Sat, Sep 7, 4:40 AM
Unknown Object (File)
Tue, Sep 3, 7:16 AM
Unknown Object (File)
Mon, Sep 2, 12:56 AM
Unknown Object (File)
Fri, Aug 30, 10:41 AM
View All 20 Files
Subscribers
imp

Details

Reviewers
None
Group Reviewers
Klara
Summary

MFC after: 1 week
Sponsored by: Klara, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 55521
Build 52410: arc lint + arc unit

Event Timeline

des created this revision.Jan 21 2024, 5:37 PM
Herald added a subscriber: imp. · View Herald TranscriptJan 21 2024, 5:37 PM
des requested review of this revision.Jan 21 2024, 5:37 PM
Harbormaster completed remote builds in B55521: Diff 133116.Jan 21 2024, 5:37 PM
des added a parent revision: D43532: bintrans: Error out if writing to the output failed..Jan 21 2024, 5:37 PM
des added a child revision: D43534: bintrans: Fix uninitialized variable..
des added a reviewer: manpages.Jan 23 2024, 12:55 PM
des removed a reviewer: manpages.
des added a comment.Jan 23 2024, 12:58 PM

On second thought, this would result in base64_decode() and uu_decode() showing the wrong file name in error messages since they use outfile and don't have routfile in scope...

des abandoned this revision.Jan 23 2024, 1:00 PM
des removed a child revision: D43534: bintrans: Fix uninitialized variable..
des removed a parent revision: D43532: bintrans: Error out if writing to the output failed..

Revision Contents
Changeset List

PathSize
usr.bin/
bintrans/
23 lines

Diff 133116

View Options

usr.bin/bintrans/uudecode.c

Loading...