Page MenuHomeFreeBSD

ktls: fix vnet-related panic in ktls_reset_receive_tag()
ClosedPublic

Authored by mm on Jan 11 2024, 12:29 PM.
Tags
None
Referenced Files
F115897587: D43400.id132638.diff
Wed, Apr 30, 3:52 AM
F115885521: D43400.diff
Wed, Apr 30, 12:22 AM
Unknown Object (File)
Thu, Apr 24, 4:01 AM
Unknown Object (File)
Mar 30 2025, 12:25 PM
Unknown Object (File)
Mar 11 2025, 1:05 AM
Unknown Object (File)
Feb 22 2025, 2:36 PM
Unknown Object (File)
Feb 16 2025, 1:08 AM
Unknown Object (File)
Jan 17 2025, 12:37 PM
Subscribers

Details

Summary

I have reproducibly triggered a panic with sorele() in ktls_reset_receive_tag() being out of vnet context when using a mlx5 with KTLS with lagg and vlan.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

mm requested review of this revision.Jan 11 2024, 12:29 PM
This revision is now accepted and ready to land.Jan 11 2024, 3:00 PM

For future reference, uploading diffs with context (e.g. with git-arc) makes reviewing easier. I don't think we need the vnet around if_rele() (in case it calls if_free), so I think this is correct.

In D43400#989566, @jhb wrote:

For future reference, uploading diffs with context (e.g. with git-arc) makes reviewing easier. I don't think we need the vnet around if_rele() (in case it calls if_free), so I think this is correct.

You can also provide context on diffs using 'git diff -U999999'.