Page MenuHomeFreeBSD

ktls: fix vnet-related panic in ktls_reset_receive_tag()
ClosedPublic

Authored by mm on Jan 11 2024, 12:29 PM.
Tags
None
Referenced Files
F102808683: D43400.diff
Sun, Nov 17, 11:23 AM
Unknown Object (File)
Fri, Nov 8, 6:05 AM
Unknown Object (File)
Thu, Nov 7, 12:29 PM
Unknown Object (File)
Wed, Nov 6, 12:19 PM
Unknown Object (File)
Wed, Oct 23, 9:57 AM
Unknown Object (File)
Oct 15 2024, 8:42 PM
Unknown Object (File)
Oct 14 2024, 8:40 PM
Unknown Object (File)
Oct 13 2024, 5:28 PM
Subscribers

Details

Summary

I have reproducibly triggered a panic with sorele() in ktls_reset_receive_tag() being out of vnet context when using a mlx5 with KTLS with lagg and vlan.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

mm requested review of this revision.Jan 11 2024, 12:29 PM
This revision is now accepted and ready to land.Jan 11 2024, 3:00 PM

For future reference, uploading diffs with context (e.g. with git-arc) makes reviewing easier. I don't think we need the vnet around if_rele() (in case it calls if_free), so I think this is correct.

In D43400#989566, @jhb wrote:

For future reference, uploading diffs with context (e.g. with git-arc) makes reviewing easier. I don't think we need the vnet around if_rele() (in case it calls if_free), so I think this is correct.

You can also provide context on diffs using 'git diff -U999999'.