tcp: missed the use of enum to check sack_changed
ClosedPublic
Actions

Authored by rscheff on Jan 6 2024, 4:00 PM.

Details

Reviewers

tuexen
cc

Group Reviewers

transport

Commits

rG541d89067add: tcp: Make use of enum for sack_changed
rG893ed42eca32: tcp: Make use of enum for sack_changed

Summary

In D28822, the return value when a SACK containing ACK
is received was converted to an enum. Missed one instance
where this is checked against.

No functional change.

MFC after: 3 day.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 55273
Build 52162: arc lint + arc unit

Event Timeline

rscheff created this revision.Jan 6 2024, 4:00 PM

Herald added a reviewer: transport. · View Herald TranscriptJan 6 2024, 4:00 PM

Herald added subscribers: glebius, melifaro, imp. · View Herald Transcript

rscheff requested review of this revision.Jan 6 2024, 4:00 PM

Harbormaster completed remote builds in B55273: Diff 132372.Jan 6 2024, 4:00 PM

tuexen accepted this revision.Jan 6 2024, 6:11 PM

This revision is now accepted and ready to land.Jan 6 2024, 6:11 PM

Closed by commit rG893ed42eca32: tcp: Make use of enum for sack_changed (authored by rscheff). · Explain WhyJan 6 2024, 7:44 PM

This revision was automatically updated to reflect the committed changes.

rscheff added a commit: rG893ed42eca32: tcp: Make use of enum for sack_changed.

rscheff added a commit: rG541d89067add: tcp: Make use of enum for sack_changed.Jan 9 2024, 12:58 PM

Revision Contents
Changeset List

Path

Size

sys/

netinet/

tcp_input.c

3 lines

Diff 132372

View Options

tcp: missed the use of enum to check sack_changedClosedPublicActions