Details

share/examples/bhyve/vmrun.sh
90–91	In my experience, if you want to pass a device through to the VM, the host driver has to be detached, in which case it'll show up in pciconf -l output as `none@pci...`. So I'm not sure how this can work.
358

christos added inline comments.Jan 2 2024, 3:05 PM

share/examples/bhyve/vmrun.sh
90–91	The example is indeed incorrect, as the driver would have to be detached first. bhyve works by passing it a `ppt` driver, so `none` (although the script will still be able to fetch its bus/slot/func) isn't supposed to be used either. https://wiki.freebsd.org/bhyve/pci_passthru The example should say `ppt0` instead of `ehci0`.

christos added inline comments.Jan 2 2024, 3:09 PM

share/examples/bhyve/vmrun.sh
358	I'll fix this in another commit because there are multiple other instances of this.

markj added inline comments.Jan 2 2024, 5:04 PM

share/examples/bhyve/vmrun.sh
90–91	Ah right, ok. Can we please also preserve backward compatibility? That is, if the passthrough device is of the form a/b/c, avoid treating it as a device name?
356	I think you can replace this pipe with `passno=$(pciconf -l \| awk -F: '{print $2"/"$3"/"$4}')`.

christos added inline comments.Jan 2 2024, 5:21 PM

share/examples/bhyve/vmrun.sh
90–91	Sure.
356	Thank you, definitely better this way

markj added inline comments.Jan 2 2024, 5:27 PM

share/examples/bhyve/vmrun.sh
356	Sorry, I meant to write `pciconf -l $pass\| awk -F: '{print $2"/"$3"/"$4}'`. I'd also name the variable something more accurate, maybe "bsl" (bus slot function).

christos retitled this revision from vmrun.sh: pass pci device name instead of bus/slot/func to vmrun.sh: allow device name arguments in pci-passthru option.Jan 2 2024, 5:43 PM

Address Mark's comments. Preserve backwards compatibility.

Harbormaster completed remote builds in B55197: Diff 132124.Jan 2 2024, 5:44 PM

Fix indentation and use if-else than test.

Harbormaster completed remote builds in B55198: Diff 132125.Jan 2 2024, 5:55 PM

markj added inline comments.Jan 2 2024, 5:57 PM

share/examples/bhyve/vmrun.sh
353–354	[0-9]* matches the empty string, but we don't want that.
354	Sorry, I meant to write "bsf".

Address Mark's comments.

Harbormaster completed remote builds in B55199: Diff 132126.Jan 2 2024, 6:02 PM

imp added inline comments.Jan 2 2024, 6:07 PM

share/examples/bhyve/vmrun.sh
356	Don't we need to preserve the domain as well?

christos added inline comments.Jan 2 2024, 6:13 PM

share/examples/bhyve/vmrun.sh
354	Sorry, I meant to write "bsf". I didn't think about it at all, thanks.
356	bhyve expects bus/slot/entry as input, so the domain field is not needed in this case.