Differential D43236

tcp_wrappers: Use default C standard version
AcceptedPublic
Actions

Authored by minsoochoo0122_proton.me on Dec 29 2023, 9:43 PM.

Tags

Referenced Files

	Unknown Object (File)
	Tue, Dec 31, 6:48 AM

	Unknown Object (File)
	Sat, Dec 7, 9:33 AM

	Unknown Object (File)
	Wed, Dec 4, 8:29 AM

	Unknown Object (File)
	Nov 17 2024, 2:33 PM

	Unknown Object (File)
	Nov 17 2024, 2:15 PM

	Unknown Object (File)
	Nov 17 2024, 12:35 PM

	Unknown Object (File)
	Sep 24 2024, 9:49 PM

	Unknown Object (File)
	Sep 24 2024, 5:51 PM

View All 38 Files

Subscribers

Contributor Reviews (src)

Details

Reviewers

emaste
minsoochoo0122_proton.me
arichardson

Group Reviewers

Contributor Reviews (src)

Test Plan

cd /libexec/tcpd
make

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 55157
Build 52046: arc lint + arc unit

Event Timeline

minsoochoo0122_proton.me created this revision.Dec 29 2023, 9:43 PM

Herald added a subscriber: imp. · View Herald TranscriptDec 29 2023, 9:43 PM

minsoochoo0122_proton.me requested review of this revision.Dec 29 2023, 9:43 PM

Harbormaster completed remote builds in B55154: Diff 131986.Dec 29 2023, 9:43 PM

minsoochoo0122_proton.me edited the test plan for this revision. (Show Details)Dec 29 2023, 9:44 PM

minsoochoo0122_proton.me added a reviewer: Contributor Reviews (src).

minsoochoo0122_proton.me added a project: Contributor Reviews (src).

minsoochoo0122_proton.me added a subscriber: Contributor Reviews (src).

minsoochoo0122_proton.me added a parent revision: D43237: Use gnu17 for buildworld.Dec 29 2023, 9:57 PM

Do you happen to have these changes available in a Git repo somewhere that I can pull from?

This revision is now accepted and ready to land.Dec 29 2023, 10:17 PM

emaste added inline comments.Dec 29 2023, 10:19 PM

contrib/tcp_wrappers/tcpd.c
48	style(9) has the function name start in column 1, int main(...

Fix function header accordign to style(9)

This revision now requires review to proceed.Dec 29 2023, 11:16 PM

Harbormaster completed remote builds in B55157: Diff 131999.Dec 29 2023, 11:16 PM

minsoochoo0122_proton.me marked an inline comment as done.Dec 29 2023, 11:17 PM

In D43236#985438, @emaste wrote:

Do you happen to have these changes available in a Git repo somewhere that I can pull from?

I pushed this change to my Github repo

minsoochoo0122_proton.me removed a parent revision: D43237: Use gnu17 for buildworld.Dec 30 2023, 5:26 AM

minsoochoo0122_proton.me added a child revision: D43237: Use gnu17 for buildworld.

minsoochoo0122_proton.me retitled this revision from tcp_wrappers: Use default C standard version for buildworld to tcp_wrappers: Use default C standard version.Dec 31 2023, 3:20 AM

minsoochoo0122_proton.me mentioned this in D43237: Use gnu17 for buildworld.Dec 31 2023, 6:49 AM

Accepted earlier by @emaste .

This revision is now accepted and ready to land.Dec 31 2023, 4:30 PM

arichardson accepted this revision.Jan 29 2024, 11:59 PM

Revision Contents
Changeset List

Path

Size

contrib/

tcp_wrappers/

1 line

libexec/

tcpd/

1 line

Diff 131999

contrib/tcp_wrappers/tcpd.c

Loading...

libexec/tcpd/Makefile

Loading...