mbuf.9: Document mtodo
ClosedPublic
Actions

Authored by jhb on Dec 27 2023, 6:51 PM.

Details

Reviewers

markj
imp

Commits

rG58836703dc30: mbuf.9: Document mtodo
rGe73b54810308: mbuf.9: Document mtodo
rG854e1fd69218: mbuf.9: Document mtodo

Summary

mtodo() accepts an mbuf and offset and returns a void * pointer to the
requested offset into the mbuf's associated data. Similar to mtod(),
no bounds checking is performed.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Dec 27 2023, 6:51 PM

Herald added a subscriber: imp. · View Herald TranscriptDec 27 2023, 6:51 PM

jhb requested review of this revision.Dec 27 2023, 6:51 PM

Harbormaster completed remote builds in B55138: Diff 131923.Dec 27 2023, 6:51 PM

I like this. Not 100% it's all correct, but I like it.

share/man/man9/mbuf.9
55	Type or void *?

This revision is now accepted and ready to land.Dec 27 2023, 8:38 PM

jhb added inline comments.Dec 27 2023, 10:40 PM

share/man/man9/mbuf.9
55	`mtod` does a cast of `(type)` on the return value. Possibly this should be `.Ft Fa type` though

imp added inline comments.Dec 27 2023, 11:19 PM

share/man/man9/mbuf.9
55	Oh right. I'm in the network stack so infrequently I'd forgotten. I think that markup might be a bit better.

markj accepted this revision.Dec 28 2023, 4:51 PM

Closed by commit rG854e1fd69218: mbuf.9: Document mtodo (authored by jhb). · Explain WhyDec 28 2023, 7:18 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG854e1fd69218: mbuf.9: Document mtodo.

jhb added a commit: rGe73b54810308: mbuf.9: Document mtodo.Jan 18 2024, 10:40 PM

jhb added a commit: rG58836703dc30: mbuf.9: Document mtodo.

Revision Contents
Changeset List

Path

Size

share/

man/

man9/

Makefile

1 line

mbuf.9

24 lines

Diff 131956

View Options

share/man/man9/Makefile