mps: Handle errors from copyout() in ioctl handlers
ClosedPublic
Actions

Authored by markj on Dec 25 2023, 5:58 PM.

Details

Reviewers

asomers
imp
ken
slm

Commits

rGf01b5e418745: mps: Handle errors from copyout() in ioctl handlers
rG0e83222347c5: mps: Handle errors from copyout() in ioctl handlers
rGbcf4a7c7ace2: mps: Handle errors from copyout() in ioctl handlers

Summary

In preparation for adding a __result_use_check annotation to copyin()
and related functions, start checking for errors from copyout() in
the mps(4) user command handler. This should make it easier to catch
bugs.

MFC after: 1 month

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 55106
Build 51995: arc lint + arc unit

Event Timeline

markj created this revision.Dec 25 2023, 5:58 PM

Herald added a reviewer: slm. · View Herald TranscriptDec 25 2023, 5:58 PM

markj requested review of this revision.Dec 25 2023, 5:58 PM

Harbormaster completed remote builds in B55106: Diff 131833.Dec 25 2023, 5:58 PM

markj added a child revision: D43177: mpr: Handle errors from copyout() in ioctl handlers.Dec 25 2023, 5:58 PM

asomers accepted this revision.Dec 25 2023, 6:19 PM

This revision is now accepted and ready to land.Dec 25 2023, 6:19 PM

imp accepted this revision.Dec 25 2023, 6:23 PM

Closed by commit rGbcf4a7c7ace2: mps: Handle errors from copyout() in ioctl handlers (authored by markj). · Explain WhyDec 26 2023, 2:05 AM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rGbcf4a7c7ace2: mps: Handle errors from copyout() in ioctl handlers.

markj added a commit: rG0e83222347c5: mps: Handle errors from copyout() in ioctl handlers.Jan 2 2024, 12:39 AM

markj added a commit: rGf01b5e418745: mps: Handle errors from copyout() in ioctl handlers.Jan 2 2024, 1:16 AM

Revision Contents
Changeset List

Path

Size

sys/

dev/

mps/

mps_user.c

31 lines

Diff 131833

View Options

mps: Handle errors from copyout() in ioctl handlersClosedPublicActions