Page MenuHomeFreeBSD
Differential D43130

ses: Add error checking for copyout() calls
ClosedPublic
Actions

Authored by markj on Dec 20 2023, 1:01 AM.
Tags
None
Referenced Files
F102936360: D43130.diff
Mon, Nov 18, 11:32 PM
Unknown Object (File)
Fri, Nov 15, 11:24 PM
Unknown Object (File)
Mon, Nov 4, 12:39 AM
Unknown Object (File)
Mon, Nov 4, 12:39 AM
Unknown Object (File)
Mon, Nov 4, 12:39 AM
Unknown Object (File)
Mon, Nov 4, 12:17 AM
Unknown Object (File)
Oct 3 2024, 8:22 AM
Unknown Object (File)
Oct 2 2024, 11:17 PM
View All 40 Files
Subscribers
None

Details

Reviewers
asomers
imp
mav
Group Reviewers
cam
Commits
rG8276e3d3f8f3: ses: Add error checking for copyout() calls
rGcd4fa9258949: ses: Add error checking for copyout() calls
rG771501e96ffd: ses: Add error checking for copyout() calls
Summary

This is in preparation for annotating copyin() and related functions
with __result_use_check.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 55038
Build 51927: arc lint + arc unit

Event Timeline

markj created this revision.Dec 20 2023, 1:01 AM
Herald added a reviewer: cam. · View Herald TranscriptDec 20 2023, 1:01 AM
markj requested review of this revision.Dec 20 2023, 1:01 AM
Harbormaster completed remote builds in B55038: Diff 131597.Dec 20 2023, 1:01 AM
asomers accepted this revision.Dec 20 2023, 1:22 AM

LGTM. Do you need help testing it? I can test it for you, if you lack appropriate hardware.

This revision is now accepted and ready to land.Dec 20 2023, 1:22 AM
markj added a comment.Dec 20 2023, 1:22 AM
In D43130#982959, @asomers wrote:

LGTM. Do you need help testing it? I can test it for you, if you lack appropriate hardware.

Yes please!

asomers added a comment.Dec 20 2023, 1:31 AM
In D43130#982962, @markj wrote:
In D43130#982959, @asomers wrote:

LGTM. Do you need help testing it? I can test it for you, if you lack appropriate hardware.

Yes please!

Ok. I'll see if I can do it tomorrow.

imp accepted this revision.Dec 20 2023, 2:38 AM

Looks good to me too

mav accepted this revision.Dec 20 2023, 3:43 PM
asomers added a comment.Dec 20 2023, 5:45 PM

@markj All tests pass on my admittedly somewhat trailing edge hardware.

markj added a comment.Dec 21 2023, 4:08 PM
In D43130#983079, @asomers wrote:

@markj All tests pass on my admittedly somewhat trailing edge hardware.

I appreciate it, thank you.

Closed by commit rG771501e96ffd: ses: Add error checking for copyout() calls (authored by markj). · Explain WhyDec 26 2023, 2:05 AM
This revision was automatically updated to reflect the committed changes.
markj added a commit: rG771501e96ffd: ses: Add error checking for copyout() calls.
markj added a commit: rGcd4fa9258949: ses: Add error checking for copyout() calls.Jan 2 2024, 12:39 AM
markj added a commit: rG8276e3d3f8f3: ses: Add error checking for copyout() calls.Jan 2 2024, 1:16 AM

Revision Contents
Changeset List

PathSize
sys/
cam/
scsi/
21 lines

Diff 131597

View Options

sys/cam/scsi/scsi_enc_ses.c

Loading...