ip_mroute: allow MRT_DEL_MFC even if there are pending upcalls
ClosedPublic
Actions

Authored by kp on Dec 13 2023, 1:01 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Jan 23, 10:11 AM

	Unknown Object (File)
	Mon, Jan 13, 4:59 PM

	Unknown Object (File)
	Dec 31 2024, 6:52 AM

	Unknown Object (File)
	Dec 11 2024, 8:30 AM

	Unknown Object (File)
	Nov 24 2024, 9:11 AM

	Unknown Object (File)
	Nov 21 2024, 10:39 AM

	Unknown Object (File)
	Nov 20 2024, 8:54 PM

	Unknown Object (File)
	Nov 17 2024, 10:32 AM

Subscribers

Details

Reviewers

glebius

Group Reviewers

network
pfsense

Commits

rG0bc82e4fbbe9: ip_mroute: allow MRT_DEL_MFC even if there are pending upcalls

Summary

In del_mfc() we try to find the forwarding entry, but that fails to find
the entry if mfc_stall_ring is not empty.

We should find the entry anyway, and destroy it (and any pending
messages) on delete.

Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kp created this revision.Dec 13 2023, 1:01 PM

Herald added subscribers: glebius, melifaro, imp. · View Herald TranscriptDec 13 2023, 1:01 PM

kp requested review of this revision.Dec 13 2023, 1:01 PM

kp added a child revision: D43032: Revert "mcast: fix memory leak in imf_purge()".

Harbormaster completed remote builds in B54913: Diff 131325.Dec 13 2023, 1:02 PM

glebius accepted this revision as: glebius.Dec 14 2023, 5:27 PM

This revision is now accepted and ready to land.Dec 14 2023, 5:27 PM

Closed by commit rG0bc82e4fbbe9: ip_mroute: allow MRT_DEL_MFC even if there are pending upcalls (authored by kp). · Explain WhyDec 14 2023, 10:00 PM

This revision was automatically updated to reflect the committed changes.

kp added a commit: rG0bc82e4fbbe9: ip_mroute: allow MRT_DEL_MFC even if there are pending upcalls.

Revision Contents
Changeset List

Path

Size

sys/

netinet/

ip_mroute.c

17 lines

Diff 131456

View Options

ip_mroute: allow MRT_DEL_MFC even if there are pending upcallsClosedPublicActions