Differential D43020

ClosedPublic
Actions

Authored by dumbbell on Dec 13 2023, 11:57 AM.

Details

Reviewers

manu

Commits

rGfe84281803d6: linuxkpi: Add `struct kset` support in <linux/kobject.h>

Summary

Why

The amdgpu DRM driver started to use it in Linux 5.18.

This is part of the update of the DRM drivers to Linux 5.18.

Depends on: D43019.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

dumbbell created this revision.Dec 13 2023, 11:57 AM

Herald added subscribers: linuxkpi, emaste, imp. · View Herald TranscriptDec 13 2023, 11:57 AM

dumbbell requested review of this revision.Dec 13 2023, 11:57 AM

manu requested changes to this revision.Dec 13 2023, 1:54 PM

manu added inline comments.

sys/compat/linuxkpi/common/include/linux/kobject.h
60	This will break kbi for mfc, I think that moving this at the end of the struct will reduce the problem.
177	style(9), need new line before function name
185	style(9)
197	style(9)

This revision now requires changes to proceed.Dec 13 2023, 1:54 PM

dumbbell added a parent revision: D43019: linuxkpi: Move `struct kobject` code to `linux_kobject.c`.Dec 13 2023, 6:25 PM

Address the concerns from @manu:

the KBI vs. MFC issue
style(9) errors

manu accepted this revision.Dec 13 2023, 6:53 PM

This revision is now accepted and ready to land.Dec 13 2023, 6:53 PM

Closed by commit rGfe84281803d6: linuxkpi: Add `struct kset` support in <linux/kobject.h> (authored by dumbbell). · Explain WhyDec 13 2023, 7:00 PM

This revision was automatically updated to reflect the committed changes.

dumbbell added a commit: rGfe84281803d6: linuxkpi: Add `struct kset` support in <linux/kobject.h>.

Revision Contents
Changeset List

Path

Size

sys/

compat/

linuxkpi/

common/

include/

linux/

kobject.h

46 lines

src/

linux_kobject.c

141 lines

Diff 131314

View Options

sys/compat/linuxkpi/common/include/linux/kobject.h