Also, remove most comments, which don't add value.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
lib/libthr/thread/thr_attr.c | ||
---|---|---|
134–136 | not sure about this to two lines |
lib/libthr/thread/thr_attr.c | ||
---|---|---|
134–136 | You mean, splitting the original single line declaring attr and dst? I think I did that to follow style(9) on ordering by decreasing sizes (because attr is the full structure whereas dst is just a pointer), since all objects are arguably (almost) equally used. But really I don't mind that much. I suspect that this style requirement comes from a time when compilers would not reorder declarations in functions, so ordering them by size may then have been useful to lower stack usage, but today I wouldn't be surprised if compilers don't follow the written order, making the point moot. |
lib/libthr/thread/thr_attr.c | ||
---|---|---|
134–136 | Yes precisely that. |