Page MenuHomeFreeBSD

llvm: Support: don't block signals around close if it can be avoided
ClosedPublic

Authored by mjg on Dec 9 2023, 7:49 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Oct 30, 6:14 AM
Unknown Object (File)
Tue, Oct 22, 9:55 AM
Unknown Object (File)
Tue, Oct 22, 9:55 AM
Unknown Object (File)
Tue, Oct 22, 9:55 AM
Unknown Object (File)
Tue, Oct 22, 9:44 AM
Unknown Object (File)
Mon, Oct 21, 9:43 AM
Unknown Object (File)
Sun, Oct 20, 1:50 PM
Unknown Object (File)
Sep 30 2024, 8:18 AM

Details

Summary

Upstream is giving radio silence, see https://github.com/llvm/llvm-project/pull/73009

There is tons of other perf breakage which I may get around to.

llvm: Support: don't block signals around close if it can be avoided

Signal blocking originally showed up in 51c2afc4b65b2782 ("Support:
Don't call close again if we get EINTR"), but it was overzealous --
there are systems where the error is known to be fine.

This commit elides signal blocking for said systems (the list is
incomplete though).

Note close() can still fail for other reasons (like ENOSPC), in which
case an error will be returned while the fd slot is cleared up.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped