Page MenuHomeFreeBSD

if_bnxt: Correcting the firmware package version parsing logic.
ClosedPublic

Authored by chandrakanth.patil_broadcom.com on Dec 7 2023, 12:27 PM.
Tags
None
Referenced Files
F102102657: D42950.diff
Thu, Nov 7, 3:42 PM
Unknown Object (File)
Sat, Oct 26, 9:45 AM
Unknown Object (File)
Sat, Oct 26, 6:40 AM
Unknown Object (File)
Sat, Oct 26, 6:40 AM
Unknown Object (File)
Sat, Oct 26, 6:40 AM
Unknown Object (File)
Sat, Oct 26, 6:29 AM
Unknown Object (File)
Wed, Oct 16, 12:14 PM
Unknown Object (File)
Mon, Oct 14, 1:36 PM
Subscribers
None

Details

Summary

The firmware package version currently appears as "Unknown" through
the sysctl interface. The parsing logic for extracting the firmware
package version from the package log has been modified to ensure
compatibility with all controllers.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

bnxt_sysctl.c
740

So why not !isspace(*p) here? Might want to have somenote what the format of pkglog is....

So this looks fine, but maybe a comment would make it a bit better. It is just moving code, I understand, but restoring the 'tab deliminated field' comment in the copied code I think would address my objections and answer my question about isspace.
So unless the answer is quite a bit different than I think, and changes to address this should be fine.

This revision is now accepted and ready to land.Feb 7 2024, 7:42 PM