The firmware package version currently appears as "Unknown" through
the sysctl interface. The parsing logic for extracting the firmware
package version from the package log has been modified to ensure
compatibility with all controllers.
Details
Details
Diff Detail
Diff Detail
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
bnxt_sysctl.c | ||
---|---|---|
740 | So why not !isspace(*p) here? Might want to have somenote what the format of pkglog is.... |
Comment Actions
So this looks fine, but maybe a comment would make it a bit better. It is just moving code, I understand, but restoring the 'tab deliminated field' comment in the copied code I think would address my objections and answer my question about isspace.
So unless the answer is quite a bit different than I think, and changes to address this should be fine.