sort: Only build FreeBSD-specific ALTMON_x stuff when ATLMON_1 is defined

[imp]

Summary

On MacOS, we bootstrap sort. Since ALTMON_* are not defined there, the
build blows up. Since we don't need this feature for the FreeBSD build
process, and since we won't use it unless we actually install the NL
files that have this data in it, just #ifdef it out for now. In the
extremely unlikely event that the FreeBSD bootstrap/build process grows
this dependency, we can evaluate the best solution then (which most
likely is going to be not depend on the local's month names).

Sponsored by: Netflix

[jrtc27]

Seems fine to me. Do we have tests for this case to ensure that we don't silently start compiling this code out even on FreeBSD if something gets screwed up?

[markj]

Seems ok to me. Please include a "Fixes:" tag in the commit message so that it's easy to find this at MFC time.

[imp]

I plan to push this EOD if I don't hear anything (since it is a build and CI breakage).
However, if there's something better in the wings, I'll back off.. and if something better comes along after my deadline, I'm totally cool deferring to that as well. (unless it is ifdef apple :).

[imp]

In D42868#977772, @jrtc27 wrote:

Seems fine to me. Do we have tests for this case to ensure that we don't silently start compiling this code out even on FreeBSD if something gets screwed up?

I believe he added tests for it in the original commit, so I think we're good.

[markj]

usr.bin/sort/bwstring.c

141

Actually, we should set *.alt = NULL here instead, or ifdef out the references in bws_month_score() as well.

[imp]

NULL out .alt out of safety concerns if ALTMON_x is undefined.

[imp]

usr.bin/sort/bwstring.c

141

I think they will tend to be NULL anyway... but an explicit setting wouldn't hurt in case my thoughts are wrong :)

[jlduran]

In D42868#977777, @imp wrote:

I plan to push this EOD if I don't hear anything (since it is a build and CI breakage).
However, if there's something better in the wings, I'll back off.. and if something better comes along after my deadline, I'm totally cool deferring to that as well. (unless it is ifdef apple :).

😂 note taken. It builds!: https://github.com/jlduran/freebsd-src/actions/runs/7064234126/job/19231839355

[markj]

usr.bin/sort/bwstring.c

141

I don't see how they would be NULL. sort_malloc() calls malloc(), not calloc().

[christos]

Thanks. If you want, I can take care of MFC'ing it along with D42847.

[christos]

In D42868#978348, @christos wrote:

Thanks. If you want, I can take care of MFC'ing it along with D42847.

@imp done.