tcp: move sysctl from tcp.do_lrd tp tcp.sack.lrd, remove sockopt for LRD
ClosedPublic
Actions

Authored by rscheff on Nov 30 2023, 3:43 PM.

Details

Reviewers

cc
tuexen
rrs
jtl
glebius
kbowling
zlei

Group Reviewers

transport

Commits

rGf42518ff1250: tcp: for LRD move sysctl from tcp.do_lrd tp tcp.sack.lrd, remove sockopt

Summary

Lost Retransmission Detection for the base stack:

Moving the sysctl control to the tcp.sack branch, as LRD only works in conjunction with SACK loss recovery - and update the tcp.4 man page accordingly.

Also, remove the sockopt to programmatically control LRD per session, as there is no known use of that functionality

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 54709
Build 51598: arc lint + arc unit

Event Timeline

rscheff requested review of this revision.Nov 30 2023, 3:43 PM

rscheff created this revision.

Harbormaster completed remote builds in B54709: Diff 130854.Nov 30 2023, 3:44 PM

rrs accepted this revision.Nov 30 2023, 3:46 PM

This revision is now accepted and ready to land.Nov 30 2023, 3:46 PM

remove the sockopt to enable/disable LRD

This revision now requires review to proceed.Nov 30 2023, 3:53 PM

Harbormaster completed remote builds in B54710: Diff 130855.Nov 30 2023, 3:53 PM

rscheff retitled this revision from tcp: move sysctl from tcp.do_lrd tp tcp.sack.lrd to tcp: move sysctl from tcp.do_lrd tp tcp.sack.lrd, remove sockopt for LRD.Nov 30 2023, 3:56 PM

rscheff edited the summary of this revision. (Show Details)

rscheff added a reviewer: zlei.

tuexen accepted this revision.Nov 30 2023, 8:02 PM

This revision is now accepted and ready to land.Nov 30 2023, 8:02 PM

Closed by commit rGf42518ff1250: tcp: for LRD move sysctl from tcp.do_lrd tp tcp.sack.lrd, remove sockopt (authored by rscheff). · Explain WhyNov 30 2023, 8:41 PM

This revision was automatically updated to reflect the committed changes.

rscheff added a commit: rGf42518ff1250: tcp: for LRD move sysctl from tcp.do_lrd tp tcp.sack.lrd, remove sockopt.