LinuxKPI: Add linux/ioport.h header
ClosedPublic
Actions

Authored by wulf on Nov 28 2023, 9:17 PM.

Details

Reviewers

Commits

Summary

Sponsored by: Serenity Cyber Security, LLC
MFC after: 1 week

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 54673
Build 51562: arc lint + arc unit

wulf requested review of this revision.Nov 28 2023, 9:17 PM

bz requested changes to this revision.Dec 8 2023, 5:50 PM

bz added inline comments.

sys/compat/linuxkpi/common/include/linux/ioport.h
10	"long" is Linux-style. I would not want to have to implement compat like this. If this is all we need this for I am pondering if it is worth redefining this "resource" to "linux_resource"?

This revision now requires changes to proceed.Dec 8 2023, 5:50 PM

Use drm-kmod version of linux/ioport.h placed in https://github.com/freebsd/drm-kmod/blob/master/linuxkpi/gplv2/include/linux/pci.h as a base.
It properly defines members of struct resource.

sys/compat/linuxkpi/common/include/linux/ioport.h
10	We defines "resource" as "linux_resource" for long time. But the problem is structure members called "resource" e.g.: https://github.com/freebsd/drm-kmod/blob/master/include/drm/ttm/ttm_bo_api.h#L138 . We have to fix the too as compilation becomes depending on header order.