Page MenuHomeFreeBSD

pf: fix mem leaks upon vnet destroy
ClosedPublic

Authored by igoro on Nov 24 2023, 1:01 PM.
Tags
None
Referenced Files
F102669024: D42747.id130644.diff
Fri, Nov 15, 3:04 PM
F102665666: D42747.id130795.diff
Fri, Nov 15, 1:57 PM
F102660405: D42747.diff
Fri, Nov 15, 12:04 PM
Unknown Object (File)
Sun, Nov 10, 4:32 AM
Unknown Object (File)
Fri, Oct 18, 1:43 AM
Unknown Object (File)
Oct 1 2024, 4:33 PM
Unknown Object (File)
Oct 1 2024, 4:33 PM
Unknown Object (File)
Sep 27 2024, 7:23 AM

Details

Summary
It adds missing cleanup actions:
- remove user defined anchor rulesets
- remove user defined ether anchor rulesets
- remove tables linked to user defined anchors
- deal with wildcard anchor peculiarities to get them removed correctly

PR:             274310
Test Plan

Tom's shell script reports whether such mem leaks are present or not. It's attached to 274310.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

igoro requested review of this revision.Nov 24 2023, 1:01 PM
sys/netpfil/pf/pf_ioctl.c
6247

Let's assert this.

6267

Let's assert that this succeeds.

  • The assertions have been added.
  • This update also proposes to apply the same assertion for the main two anchors (existing code).
This revision was not accepted when it landed; it landed in state Needs Review.Nov 29 2023, 6:06 PM
Closed by commit rG0626d30e41cb: pf: fix mem leaks upon vnet destroy (authored by igoro, committed by kp). · Explain Why
This revision was automatically updated to reflect the committed changes.