Differential D42580

makefs cd9660: Unexpand a few TAILQ macros
ClosedPublic
Actions

Authored by jhb on Nov 13 2023, 10:29 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Jan 24, 5:54 PM

	Unknown Object (File)
	Fri, Jan 24, 5:08 PM

	Unknown Object (File)
	Fri, Jan 24, 12:08 AM

	Unknown Object (File)
	Thu, Jan 23, 6:37 PM

	Unknown Object (File)
	Jan 10 2025, 12:38 PM

	Unknown Object (File)
	Jan 10 2025, 12:35 PM

	Unknown Object (File)
	Jan 10 2025, 7:57 AM

	Unknown Object (File)
	Dec 22 2024, 5:46 AM

View All 55 Files

Subscribers

Details

Reviewers

emaste
imp

Commits

rGa6817cd6fac8: makefs cd9660: Unexpand a few TAILQ macros
rG3a54d200ae87: makefs cd9660: Unexpand a few TAILQ macros
rGc06962057bed: makefs cd9660: Unexpand a few TAILQ macros

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Nov 13 2023, 10:29 PM

Herald added a subscriber: imp. · View Herald TranscriptNov 13 2023, 10:29 PM

jhb requested review of this revision.Nov 13 2023, 10:29 PM

jhb added a parent revision: D42579: bsd.sys.mk: Disable -Wdangling-reference for GCC 13+.

Harbormaster completed remote builds in B54404: Diff 130053.Nov 13 2023, 10:30 PM

jhb added a child revision: D42581: makefs: Quiet a -Wdangling-pointer warning in cd9660_generate_path_table.Nov 13 2023, 10:30 PM

imp accepted this revision.Nov 14 2023, 12:21 AM

This revision is now accepted and ready to land.Nov 14 2023, 12:21 AM

What's the reason for this (or, how does it relate to GCC13)?

In D42580#971586, @emaste wrote:

What's the reason for this (or, how does it relate to GCC13)?

Hmm, it is only tangentially related. The next commit quiets a false positive warning this code raised, but I noticed the direct tqh_first use while investigating that warning.

Hmm, it is only tangentially related.

Ah, OK. I was wondering if the list/queue macros somehow tripped a GCC13 warning and something was done in the macros themselves to suppress the warning.

Closed by commit rGc06962057bed: makefs cd9660: Unexpand a few TAILQ macros (authored by jhb). · Explain WhyNov 15 2023, 2:40 AM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rGc06962057bed: makefs cd9660: Unexpand a few TAILQ macros.

jhb added a commit: rG3a54d200ae87: makefs cd9660: Unexpand a few TAILQ macros.Jan 3 2024, 5:50 PM

jhb added a commit: rGa6817cd6fac8: makefs cd9660: Unexpand a few TAILQ macros.Nov 30 2024, 7:09 PM

Revision Contents
Changeset List

Path

Size

usr.sbin/

makefs/

6 lines

Diff 130115

usr.sbin/makefs/cd9660.c

Loading...