Page MenuHomeFreeBSD

bsdbox: fix the build
AcceptedPublic

Authored by kevans on Nov 8 2023, 6:33 AM.
Tags
None
Referenced Files
Unknown Object (File)
Oct 1 2024, 4:33 PM
Unknown Object (File)
Sep 24 2024, 2:46 AM
Unknown Object (File)
Sep 16 2024, 11:47 PM
Unknown Object (File)
Sep 9 2024, 2:07 AM
Unknown Object (File)
Sep 8 2024, 6:35 PM
Unknown Object (File)
Aug 14 2024, 1:47 PM
Unknown Object (File)
Aug 13 2024, 7:34 PM
Unknown Object (File)
Aug 13 2024, 7:27 PM

Details

Reviewers
imp
adrian
Summary

hostapd is removed for now because it's a little less trivial with
recent wpa architecture. The rest is adopting to ncurses and ifconfig
changes, as well as a switch in PIE default.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 54325
Build 51215: arc lint + arc unit

Event Timeline

kevans requested review of this revision.Nov 8 2023, 6:33 AM
kevans created this revision.

make -C lib/libifconfig && make -C lib/libnv && make -C tools/bsdbox works. Thanks!

tools/bsdbox/Makefile
75

Why not -lifconfig like the others?

tools/bsdbox/Makefile
75

I was just following what we did in rescue here, but I'm pretty sure it's because libifconfig is an INTERNALLIB so it doesn't end up in the place you'd expect in the sysroot we build against

This looks fine... Did I see you had hostap added back somewhere else?

tools/bsdbox/Makefile
7

Why no pie? Is a restriction of crunchgen? If so it should be in the mn page (separate commit is fine).

75

Funny... I almost added 'because it's an internal lib' to the end of my comment, but didn't want to lead the witness :)

This revision is now accepted and ready to land.Nov 10 2023, 9:44 PM
In D42498#970724, @imp wrote:

This looks fine... Did I see you had hostap added back somewhere else?

Yeah, one of the later changes brings it back. I've already merged the crunchgen change, so I might just squash these two together.

tools/bsdbox/Makefile
7

I'm not sure anymore. I had added it as a response to a build error, but I'm starting to think the build error was that I hadn't built the prerequisite libs first in that .OBJDIR- for a little bit I had forgotten that crunchgen will only rebuild the PROGS, not {SH,}LIBS. I'll axe it.