libnetmap: change interface name character exclusion approach

[franco_opnsense.org]

Summary

When trying to use a VLAN device (e.g. "em0.123") with a dot
the library fails to parse the interface correctly. The former
pattern is much too restrictive given that almost all characters
can be coerced into a device name via ifconfig.

Remove the particularly restrictive validation. Some characters
still cannot be used as an interface name as they are used as
delimiters in the syntax, but this allows to be able to use most
of them without an issue.

Test Plan

Tested and shipped in OPNsense 23.7.7 with Suricata version 6 and 7.

Revised approach via https://github.com/luigirizzo/netmap/pull/940

[vmaffione]

{ and } are missing.
Makes sense to me in general, but please also open a pull request here https://github.com/luigirizzo/netmap/
where the libnetmap developer can see it.

[franco_opnsense.org]

• libnetmap: also add '{' and '}'

[franco_opnsense.org]

Updated as requested and also pushed here for review https://github.com/luigirizzo/netmap/pull/940

[franco_opnsense.org]

• libnetmap: different approach as discussed on GitHub upstream

[vmaffione]

Do you need me to commit this?

[franco_opnsense.org]

@vmaffione yes I am not a committer