Page MenuHomeFreeBSD

Check to see if ZFS is available before invoking bectl
Needs ReviewPublic

Authored by gordon on Nov 2 2023, 11:36 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Oct 30, 11:43 AM
Unknown Object (File)
Oct 1 2024, 4:04 PM
Unknown Object (File)
Sep 24 2024, 9:31 AM
Unknown Object (File)
Sep 18 2024, 6:03 AM
Unknown Object (File)
Sep 10 2024, 1:07 PM
Unknown Object (File)
Sep 8 2024, 12:01 PM
Unknown Object (File)
Sep 7 2024, 9:31 PM
Unknown Object (File)
Sep 6 2024, 3:30 AM
Subscribers

Details

Summary

bectl will unconditionally load the ZFS module. For systems not running ZFS, we shouldn't be spuriously loading ZFS just because we ran freebsd-update install.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

gordon added reviewers: emaste, kevans.

We have a fix for this already in the tree; bectl/libbe was never meant to trigger loading of zfs.ko in the first place.

We could bring it back to stable/12, too, if we need to... it's been soaking for quite a while.

We have a fix for this already in the tree; bectl/libbe was never meant to trigger loading of zfs.ko in the first place.

We could bring it back to stable/12, too, if we need to... it's been soaking for quite a while.

I went ahead and tested it on and brought it back to stable/12 in case you're trying to errata this or something...

I mostly just noticed this on a fresh UFS based install. Do you think it would be good to have both checks (one in bectl and one in freebsd-update)?

I mostly just noticed this on a fresh UFS based install. Do you think it would be good to have both checks (one in bectl and one in freebsd-update)?

IMO no since this was really anomalous behavior, but I'd grab a second opinion from our resident freebsd-update expert @emaste to be sure...