net80211: move net_epoch into net80211
ClosedPublic
Actions

Authored by bz on Nov 1 2023, 12:26 AM.

Details

Reviewers

glebius
adrian

Group Reviewers

wireless

Commits

rGf9ac06af3b2d: net80211: move net_epoch into net80211
rG8e599ff98d48: net80211: move net_epoch into net80211
rGde607e3c230b: net80211: move net_epoch into net80211

Summary

Move the net_epoch into net80211 around the if_input calls and out of
the driver (in this first case LinuxKPI). This reduces coverage but
also allows us to alloc in calls like (*ampdu_rx_start) which do not
actually pass data up the stack.

This reverts b65f813c1ab99448278961c5ca80dc422b1eae29, 21c4082de9e2cf9a0fd81a9a981ab06022956847, 17c328b6aebfa03cd1c2cbfbbc617e3b341bf1e4, af2441fbc7fa9e522e7f8697e5a181bdd4ff9e00, and 6c3e93cb5a4aa4b8a2d8d4d326f2a7c34d3a4458 for ath.

Sposnored by: The FreeBSD Foundation
MFC after: 3 days

Test Plan

For people to review and test the entire change.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 54235
Build 51125: arc lint + arc unit

Event Timeline

bz created this revision.Nov 1 2023, 12:26 AM

Herald added subscribers: linuxkpi, melifaro, emaste, imp. · View Herald TranscriptNov 1 2023, 12:26 AM

bz requested review of this revision.Nov 1 2023, 12:26 AM

Harbormaster completed remote builds in B54235: Diff 129573.Nov 1 2023, 12:26 AM

I think it's fine, it just means we can't batch a single epoch call inside the driver when it does encap/decap for us!

This revision is now accepted and ready to land.Nov 1 2023, 1:11 AM

Add all the reverts I could find needed for wirelress drivers so people can
better review and test. My builds are currently running.

Revert "Widen EPOCH(9) usage in PCI WLAN drivers."
Revert "Widen EPOCH(9) usage in USB WLAN drivers."
Revert "Enter the network epoch in USB WiFi drivers when processing input"
Revert "[ath] Attempt to fix epoch handling."
ath: Revert "Use NET_TASK_INIT() and NET_GROUPTASK_INIT() for drivers that process"

This revision now requires review to proceed.Nov 3 2023, 10:13 PM

Harbormaster completed remote builds in B54275: Diff 129708.Nov 3 2023, 10:13 PM

bz edited the summary of this revision. (Show Details)Nov 3 2023, 10:15 PM

bz edited the test plan for this revision. (Show Details)

bz added reverted changes: rGaf2441fbc7fa: [ath] Attempt to fix epoch handling., rG6c3e93cb5a4a: Use NET_TASK_INIT() and NET_GROUPTASK_INIT() for drivers that process, rG21c4082de9e2: Widen EPOCH(9) usage in USB WLAN drivers., rG17c328b6aebf: Enter the network epoch in USB WiFi drivers when processing input.

adrian accepted this revision.Nov 3 2023, 11:12 PM

This revision is now accepted and ready to land.Nov 3 2023, 11:12 PM

Closed by commit rGde607e3c230b: net80211: move net_epoch into net80211 (authored by bz). · Explain WhyDec 1 2023, 12:56 AM

This revision was automatically updated to reflect the committed changes.

bz added a commit: rGde607e3c230b: net80211: move net_epoch into net80211.

bz added a commit: rG8e599ff98d48: net80211: move net_epoch into net80211.Feb 18 2024, 9:11 PM

bz added a commit: rGf9ac06af3b2d: net80211: move net_epoch into net80211.Jun 19 2024, 4:33 PM