Page MenuHomeFreeBSD
Differential D42369

bsdinstall: Remove unused variables in fetchmissingdists
ClosedPublic
Actions

Authored by fernape on Oct 26 2023, 12:19 PM.
Tags
None
Referenced Files
F102054208: D42369.diff
Thu, Nov 7, 1:19 AM
Unknown Object (File)
Thu, Oct 31, 2:49 PM
Unknown Object (File)
Sat, Oct 26, 3:22 PM
Unknown Object (File)
Fri, Oct 18, 4:45 AM
Unknown Object (File)
Thu, Oct 17, 1:48 PM
Unknown Object (File)
Tue, Oct 15, 1:28 AM
Unknown Object (File)
Mon, Oct 14, 1:32 PM
Unknown Object (File)
Mon, Oct 14, 1:32 PM
View All 72 Files
Subscribers
garga
imp
jlduran
jrtc27

Details

Reviewers
bz
• karels
imp
Group Reviewers
Src Committers
Commits
rG47535ba3d35e: bsdinstall: Remove unused variables in fetchmissingdists
Summary

ALL_DISTRIBUTIONS and VERIFY_MANIFEST_SIG

They are neither used in the script nor exported.
Not referenced anywhere in bsdinstall/*

Test Plan

Apply patch and try to run an installation in a jail.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 54173
Build 51063: arc lint + arc unit

Event Timeline

fernape created this revision.Oct 26 2023, 12:19 PM
Herald added subscribers: jrtc27, imp. · View Herald TranscriptOct 26 2023, 12:19 PM
fernape requested review of this revision.Oct 26 2023, 12:19 PM
Harbormaster completed remote builds in B54173: Diff 129405.Oct 26 2023, 12:19 PM
fernape added a reviewer: Src Committers.Oct 26 2023, 12:20 PM
jlduran added a subscriber: jlduran.Oct 26 2023, 10:13 PM
jlduran added inline comments.
usr.sbin/bsdinstall/scripts/fetchmissingdists
56

Fixes 40923b0c81cc2c151388ec5ead59f4bed89ac432?

78

VERIFY_MANIFEST_SIG looks like the basis of an unimplemented feature, reading the xxx comment below, left over from 40923b0c81cc2c151388ec5ead59f4bed89ac432.

fernape added a comment.Nov 24 2023, 1:58 PM

Ping!

fernape added a comment.Jan 18 2024, 11:11 AM

Friendly ping.

fernape added a comment.Apr 26 2024, 5:59 PM

Ping

garga added a subscriber: garga.Apr 29 2024, 10:40 PM
In D42369#1025343, @fernape wrote:

Ping

It seems like your review is being ignored for months. Maybe if you look for who made last changes in these files and ask them directly could help. Or even sending an email to freebsd-current asking for people to take a look here

fernape added reviewers: bz, • karels.May 5 2024, 5:02 PM
imp accepted this revision.May 9 2024, 10:11 PM

Since these aren't exported or used anywhere, I think they are safe to remove.

This revision is now accepted and ready to land.May 9 2024, 10:11 PM
Closed by commit rG47535ba3d35e: bsdinstall: Remove unused variables in fetchmissingdists (authored by fernape). · Explain WhyMay 12 2024, 5:26 PM
This revision was automatically updated to reflect the committed changes.
fernape added a commit: rG47535ba3d35e: bsdinstall: Remove unused variables in fetchmissingdists.
fernape added a comment.May 12 2024, 5:26 PM

Thanks for the review!

Revision Contents
Changeset List

PathSize
usr.sbin/
bsdinstall/
scripts/
3 lines

Diff 129405

View Options

usr.sbin/bsdinstall/scripts/fetchmissingdists

Loading...