RB_HALT does not mean poweroff, RB_POWEROFF does.
Details
Details
- Reviewers
markj jhb jhibbits - Group Reviewers
PowerPC - Commits
- rGaaebd6d069f5: powerpc: better handling of shutdown flags
rG41e26e8288f1: powerpc: better handling of shutdown flags
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 54140 Build 51030: arc lint + arc unit
Event Timeline
sys/powerpc/powermac/cuda.c | ||
---|---|---|
751 | This one doesn't match the others. The others handle poweroff, reset, and halt. You want something more like (there's a better way, of course): if ((howto & RB_POWEROFF) != 0) cmd[1] = CMD_POWEROFF; else if ((howto & RB_HALT) == 0) cmd[1] = CMD_RESET; if (cmd[1] != 0) { cuda_poll.... cuda_send.... } while (1) cuda_poll... |