tests: fix ATF_TESTS_PYTEST no clean build
ClosedPublic
Actions

Authored by glebius on Oct 19 2023, 5:20 AM.

Tags

None

Referenced Files

	F109367755: D42283.diff
	Tue, Feb 4, 3:46 AM

	Unknown Object (File)
	Sun, Feb 2, 2:49 PM

	Unknown Object (File)
	Thu, Jan 16, 8:54 AM

	Unknown Object (File)
	Fri, Jan 10, 7:14 AM

	Unknown Object (File)
	Dec 8 2024, 11:03 PM

	Unknown Object (File)
	Nov 15 2024, 3:50 AM

	Unknown Object (File)
	Oct 9 2024, 10:32 AM

	Unknown Object (File)
	Oct 3 2024, 3:19 PM

Subscribers

Details

Reviewers

jmmv
melifaro
asomers

Commits

rG6120673f7566: tests: fix ATF_TESTS_PYTEST no clean build

Summary

The hack with .xtmp file was effectively making the make to
ignore changes to the sources, breaking NO_CLEAN builds. The
hack can be actually omitted as setting SCRIPTSNAME_${_T} for
every test is sufficient to prevent renaming by bsd.prog.mk.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 54063
Build 50953: arc lint + arc unit

Event Timeline

glebius created this revision.Oct 19 2023, 5:20 AM

Herald added subscribers: emaste, imp, bdrewery. · View Herald TranscriptOct 19 2023, 5:20 AM

glebius requested review of this revision.Oct 19 2023, 5:20 AM

Harbormaster completed remote builds in B54063: Diff 129053.Oct 19 2023, 5:20 AM

melifaro accepted this revision.Oct 19 2023, 7:02 PM

This revision is now accepted and ready to land.Oct 19 2023, 7:02 PM

Closed by commit rG6120673f7566: tests: fix ATF_TESTS_PYTEST no clean build (authored by glebius). · Explain WhyOct 20 2023, 5:47 PM

This revision was automatically updated to reflect the committed changes.

glebius added a commit: rG6120673f7566: tests: fix ATF_TESTS_PYTEST no clean build.

markj added a reverting change: rGe8f035763083: Revert "tests: fix ATF_TESTS_PYTEST no clean build".Oct 22 2023, 5:15 PM

Revision Contents
Changeset List

Path

Size

share/

mk/

atf.test.mk

30 lines

Diff 129053

View Options

tests: fix ATF_TESTS_PYTEST no clean buildClosedPublicActions