tests: fix ATF_TESTS_PYTEST no clean build
ClosedPublic
Actions

Authored by glebius on Oct 19 2023, 5:20 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Mar 13, 11:53 PM

	Unknown Object (File)
	Thu, Mar 13, 11:06 PM

	Unknown Object (File)
	Mon, Mar 10, 9:34 AM

	Unknown Object (File)
	Fri, Feb 21, 4:09 PM

	Unknown Object (File)
	Feb 18 2025, 8:29 AM

	Unknown Object (File)
	Feb 9 2025, 6:16 PM

	Unknown Object (File)
	Feb 8 2025, 8:36 PM

	Unknown Object (File)
	Feb 8 2025, 1:57 AM

Subscribers

Details

Reviewers

jmmv
melifaro
asomers

Commits

rG6120673f7566: tests: fix ATF_TESTS_PYTEST no clean build

Summary

The hack with .xtmp file was effectively making the make to
ignore changes to the sources, breaking NO_CLEAN builds. The
hack can be actually omitted as setting SCRIPTSNAME_${_T} for
every test is sufficient to prevent renaming by bsd.prog.mk.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

glebius created this revision.Oct 19 2023, 5:20 AM

Herald added subscribers: emaste, imp, bdrewery. · View Herald TranscriptOct 19 2023, 5:20 AM

glebius requested review of this revision.Oct 19 2023, 5:20 AM

Harbormaster completed remote builds in B54063: Diff 129053.Oct 19 2023, 5:20 AM

melifaro accepted this revision.Oct 19 2023, 7:02 PM

This revision is now accepted and ready to land.Oct 19 2023, 7:02 PM

Closed by commit rG6120673f7566: tests: fix ATF_TESTS_PYTEST no clean build (authored by glebius). · Explain WhyOct 20 2023, 5:47 PM

This revision was automatically updated to reflect the committed changes.

glebius added a commit: rG6120673f7566: tests: fix ATF_TESTS_PYTEST no clean build.

markj added a reverting change: rGe8f035763083: Revert "tests: fix ATF_TESTS_PYTEST no clean build".Oct 22 2023, 5:15 PM

Revision Contents
Changeset List

Path

Size

share/

mk/

atf.test.mk

30 lines

Diff 129172

View Options

tests: fix ATF_TESTS_PYTEST no clean buildClosedPublicActions