Differential D42169

pf: Free pf_rule_items when state is not created
ClosedPublic
Actions

Authored by vegeta_tuxpowered.net on Oct 12 2023, 4:20 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Sep 12, 7:36 AM

	Unknown Object (File)
	Sun, Sep 8, 10:54 AM

	Unknown Object (File)
	Sat, Sep 7, 12:24 PM

	Unknown Object (File)
	Thu, Sep 5, 2:49 AM

	Unknown Object (File)
	Mon, Sep 2, 2:26 PM

	Unknown Object (File)
	Tue, Aug 27, 1:28 AM

	Unknown Object (File)
	Aug 19 2024, 10:41 AM

	Unknown Object (File)
	Aug 8 2024, 8:31 PM

View All 17 Files

Subscribers

Details

Reviewers

Commits

rG68513b4102dc: pf: Free pf_rule_items when state is not created
rG4d19eceaefb7: pf: Free pf_rule_items when state is not created

Summary

This addresses the issues of pf_rule_times leaking in case of stateless rules and in case of state creation failures, like hitting the state limit.

Sponsored by: InnoGames GmbH

Test Plan

I've created a rulesets with a match rule and with a pass rule with state limit or with no state. After sending a few packets through I've unloaded pf.ko and that resulted with memory leak being logged. With this patch the leak is not logged anymore.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

vegeta_tuxpowered.net created this revision.Oct 12 2023, 4:20 PM

Herald added subscribers: glebius, melifaro, farrokhi, imp. · View Herald TranscriptOct 12 2023, 4:20 PM

vegeta_tuxpowered.net requested review of this revision.Oct 12 2023, 4:20 PM

vegeta_tuxpowered.net edited the summary of this revision. (Show Details)

This revision was not accepted when it landed; it landed in state Needs Review.Oct 12 2023, 7:18 PM

Closed by commit rG4d19eceaefb7: pf: Free pf_rule_items when state is not created (authored by vegeta_tuxpowered.net, committed by kp). · Explain Why

This revision was automatically updated to reflect the committed changes.

kp added a commit: rG4d19eceaefb7: pf: Free pf_rule_items when state is not created.

kp added a commit: rG68513b4102dc: pf: Free pf_rule_items when state is not created.Oct 19 2023, 8:52 AM

Revision Contents
Changeset List

Path

Size

sys/

netpfil/

pf/

11 lines

Diff 128672

sys/netpfil/pf/pf.c

Loading...