Page MenuHomeFreeBSD

vt(4): Skip vt_flush() for nested panics
ClosedPublic

Authored by dumbbell on Oct 2 2023, 10:18 PM.
Tags
None
Referenced Files
F102720927: D42056.diff
Sat, Nov 16, 8:27 AM
Unknown Object (File)
Oct 16 2024, 7:12 PM
Unknown Object (File)
Oct 15 2024, 2:30 AM
Unknown Object (File)
Oct 14 2024, 4:21 AM
Unknown Object (File)
Oct 12 2024, 8:36 AM
Unknown Object (File)
Oct 11 2024, 12:45 AM
Unknown Object (File)
Oct 10 2024, 11:37 PM
Unknown Object (File)
Oct 10 2024, 12:17 PM
Subscribers

Details

Summary

Why

If there is a problem with DRM drivers or in their integration with vt(4) and displaying something on the console triggers a panic, there is a high chance that displaying that panic will trigger another one, recursively.

How

If vt_flush() is called and it detects is is called resursively from another panic, it return immediately, doing nothing, to avoid the risk of triggering another panic.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

sys/dev/vt/vt_core.c
1489

Extra blank line.

3117

Is this supposed to be part of this patch ?

dumbbell added inline comments.
sys/dev/vt/vt_core.c
1489

Removed extra blank line.

3117

Removed lines that were not supposed to be in the patch.

This revision is now accepted and ready to land.Nov 24 2023, 4:21 PM
This revision was automatically updated to reflect the committed changes.