Differential D41953

videomode: Regenerate files
ClosedPublic
Actions

Authored by jhb on Sep 23 2023, 10:04 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Nov 12, 6:46 PM

	Unknown Object (File)
	Sun, Nov 10, 9:03 PM

	Unknown Object (File)
	Fri, Oct 18, 2:50 AM

	Unknown Object (File)
	Oct 2 2024, 5:48 PM

	Unknown Object (File)
	Oct 2 2024, 8:41 AM

	Unknown Object (File)
	Oct 2 2024, 1:14 AM

	Unknown Object (File)
	Oct 1 2024, 4:01 PM

	Unknown Object (File)
	Oct 1 2024, 12:22 AM

View All 49 Files

Subscribers

None

Details

Reviewers

imp
emaste

Commits

rG62ba76f3d149: videomode: Regenerate files
rG43a0b925c1b3: videomode: Regenerate files
rGfc3cc652e500: videomode: Regenerate files

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb requested review of this revision.Sep 23 2023, 10:04 PM

jhb created this revision.

jhb added a parent revision: D41952: videomode/devlist2h.awk: Don't include $FreeBSD$ in generated files.

Harbormaster completed remote builds in B53688: Diff 127690.Sep 23 2023, 10:04 PM

jhb added a child revision: D41954: Remove a few more stray __FBSDID uses.Sep 23 2023, 10:04 PM

imp accepted this revision.Sep 23 2023, 10:19 PM

This revision is now accepted and ready to land.Sep 23 2023, 10:19 PM

emaste accepted this revision.Sep 24 2023, 12:43 AM

emaste added inline comments.

sys/dev/videomode/ediddevs.h
5	this seems spurious too

jhb added inline comments.Sep 25 2023, 2:49 PM

sys/dev/videomode/ediddevs.h
5	This is because the commit that imported this file imported a stale version. ediddevs was at revision 1.2 when first imported in commit 0761549550dad58bfcc0f227ba6ffa78b4d8c017, but the generated files that were imported in that commit were based on the older 1.1 version. It seems the 1.2 version just added the new comment.

emaste added inline comments.Sep 25 2023, 2:53 PM

sys/dev/videomode/ediddevs.h
5	Yeah. I'm just not sure this line adds any value, I'd be tempted to just take it out of the generation script

Closed by commit rGfc3cc652e500: videomode: Regenerate files (authored by jhb). · Explain WhySep 25 2023, 2:58 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rGfc3cc652e500: videomode: Regenerate files.

jhb added a commit: rG43a0b925c1b3: videomode: Regenerate files.Oct 24 2023, 6:39 PM

jhb added a commit: rG62ba76f3d149: videomode: Regenerate files.

Revision Contents
Changeset List

Path

Size

sys/

dev/

videomode/

13 lines

ediddevs_data.h

3 lines

Diff 127781

sys/dev/videomode/ediddevs.h

Loading...

sys/dev/videomode/ediddevs_data.h

Loading...