freebsd-update: do not restart jailed sshd
ClosedPublic
Actions

Authored by emaste on Sep 16 2023, 8:54 PM.

Details

Reviewers

otis
kevans
gjb
cperciva

Commits

rG78534afbcab6: freebsd-update: do not restart sshd when updating jail/basedir
rG877d15d57931: freebsd-update: do not restart sshd when updating jail/basedir
rGcce342e21357: freebsd-update: do not restart sshd when updating jail/basedir
rG8ee97b1928e7: freebsd-update: do not restart sshd when updating jail/basedir

Summary

In 6cd1bc531609 for PR 263489 I changed freebsd-update to restart sshd after upgrade, to avoid an upgrade-related incompatibility that made it impossible to login.

This is intended to avoid losing access to remote hosts, and ought not apply to upgrading a jail.

PR: 263489, 272282

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

emaste requested review of this revision.Sep 16 2023, 8:54 PM

emaste created this revision.

Test $BASEDIR instead of $JAIL; we should not do the sshd restart dance for -b either.

I see inconsistent use of quotes around variable dereference (sometimes ${BASEDIR, sometimes "${BASEDIR}"). Other than that LGTM.

I'll test it on some jails I have left to update.

Tested, working, LGTM.

This revision is now accepted and ready to land.Sep 17 2023, 10:26 AM

I was going to complain from the description that I could only have access to the jail and be updating from within, but I reckon BASEDIR would be / in that case