newvers.sh: Avoid picking up stray envars.
ClosedPublic
Actions

Authored by des on Sep 13 2023, 1:09 PM.

Details

Reviewers

gallatin
sjg
bdrewery
gordon
cperciva
emaste

Commits

rG525c3ef318f8: newvers.sh: Avoid picking up stray envars.
rGf92a598782c2: newvers.sh: Avoid picking up stray envars.
rG9f16abf8d356: newvers.sh: Avoid picking up stray envars.

Summary

89f361f742ae added a mechanism to allow arbitrary overrides from the
command line. Unfortunately, it also had the (likely unintended)
effect of allowing RELEASE and VERSION to be passed in from the
environment, and Makefile.inc1 happens to define VERSION for the
benefit of pkgbase. To restore the status quo, unset RELEASE and
VERSION at the top of the script.

Fixes: 89f361f742ae
MFC after: 3 days

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 53574
Build 50465: arc lint + arc unit

Event Timeline

des created this revision.Sep 13 2023, 1:09 PM

Herald added a subscriber: imp. · View Herald TranscriptSep 13 2023, 1:09 PM

des requested review of this revision.Sep 13 2023, 1:09 PM

Harbormaster completed remote builds in B53573: Diff 127331.Sep 13 2023, 1:09 PM

less intrusive change

Harbormaster completed remote builds in B53574: Diff 127332.Sep 13 2023, 1:22 PM

des edited the summary of this revision. (Show Details)Sep 13 2023, 1:23 PM

des added reviewers: gordon, cperciva.

Thank you!

This revision is now accepted and ready to land.Sep 13 2023, 1:42 PM

This is likely a good change, though it was handy for detecting when on is 32 running on 64bit kernel... I used it for that not knowing this is a recent change..

Thanks - this should not impact us

emaste accepted this revision.Sep 13 2023, 6:02 PM

Closed by commit rG9f16abf8d356: newvers.sh: Avoid picking up stray envars. (authored by des). · Explain WhySep 13 2023, 6:12 PM

This revision was automatically updated to reflect the committed changes.

des added a commit: rG9f16abf8d356: newvers.sh: Avoid picking up stray envars..

This should be fine as far as FreeBSD Update builds are concerned.

des added a commit: rGf92a598782c2: newvers.sh: Avoid picking up stray envars..Sep 14 2023, 8:57 AM

des added a commit: rG525c3ef318f8: newvers.sh: Avoid picking up stray envars..Sep 14 2023, 3:03 PM